Chromium Code Reviews Chromium Code Reviews
Issue 2070483002:
Add PRESUBMIT rule to make sure IPC changes are security reviewed. (Closed)
Base URL: https://chromium.googlesource.com/chromium/src.git@master| OLD | NEW |
|---|---|
| 1 # For Linux sandboxing related changes only. Regular content/ | 1 # For Linux sandboxing related changes only. Regular content/ |
| 2 # OWNERS own content/common/. | 2 # OWNERS own content/common/. |
| 3 jln@chromium.org | 3 jln@chromium.org |
| 4 | 4 |
| 5 # For security review of sandboxes | 5 # For security review of sandboxes |
| 6 per-file sandbox_win.*=set noparent | 6 per-file sandbox_win.*=set noparent |
| 7 per-file sandbox_win.*=file://sandbox/win/OWNERS | 7 per-file sandbox_win.*=file://sandbox/win/OWNERS |
| 8 | 8 |
| 9 # Mac Sandbox. | 9 # Mac Sandbox. |
| 10 per-file sandbox_init_mac.*=rsesek@chromium.org | 10 per-file sandbox_init_mac.*=rsesek@chromium.org |
| 11 per-file sandbox_mac*=rsesek@chromium.org | 11 per-file sandbox_mac*=rsesek@chromium.org |
| 12 per-file *.sb=set noparent | 12 per-file *.sb=set noparent |
| 13 per-file *.sb=rsesek@chromium.org | 13 per-file *.sb=rsesek@chromium.org |
| 14 | 14 |
| 15 per-file pepper*=ananta@chromium.org | 15 per-file pepper*=ananta@chromium.org |
| 16 per-file pepper*=bauerb@chromium.org | 16 per-file pepper*=bauerb@chromium.org |
| 17 per-file plugin*=ananta@chromium.org | 17 per-file plugin*=ananta@chromium.org |
| 18 per-file plugin*=bauerb@chromium.org | 18 per-file plugin*=bauerb@chromium.org |
| 19 | 19 |
| 20 # Changes to IPC messages require a security review to avoid introducing | 20 per-file *_messages*.h=set noparent |
|
dcheng
2016/06/15 10:42:27
The loss in coverage from this seems relatively mi
| |
| 21 # new sandbox escapes. | 21 per-file *_messages*.h=file://ipc/SECURITY_OWNERS |
| 22 per-file *_message*.h=set noparent | |
| 23 per-file *_message*.h=dcheng@chromium.org | |
| 24 per-file *_message*.h=inferno@chromium.org | |
| 25 per-file *_message*.h=jln@chromium.org | |
| 26 per-file *_message*.h=jschuh@chromium.org | |
| 27 per-file *_message*.h=kenrb@chromium.org | |
| 28 per-file *_message*.h=mkwst@chromium.org | |
| 29 per-file *_message*.h=nasko@chromium.org | |
| 30 per-file *_message*.h=palmer@chromium.org | |
| 31 per-file *_message*.h=tsepez@chromium.org | |
| 32 per-file *_message*.h=wfh@chromium.org | |
| 33 | 22 |
| 34 per-file *_messages.cc=set noparent | 23 per-file *_messages.cc=set noparent |
| 35 per-file *_messages.cc=dcheng@chromium.org | 24 per-file *_messages.cc=file://ipc/SECURITY_OWNERS |
| 36 per-file *_messages.cc=inferno@chromium.org | |
| 37 per-file *_messages.cc=jln@chromium.org | |
| 38 per-file *_messages.cc=jschuh@chromium.org | |
| 39 per-file *_messages.cc=kenrb@chromium.org | |
| 40 per-file *_messages.cc=mkwst@chromium.org | |
| 41 per-file *_messages.cc=nasko@chromium.org | |
| 42 per-file *_messages.cc=palmer@chromium.org | |
| 43 per-file *_messages.cc=tsepez@chromium.org | |
| 44 per-file *_messages.cc=wfh@chromium.org | |
| 45 | 25 |
| 46 per-file *param_traits*.h=set noparent | 26 per-file *param_traits*.*=set noparent |
| 47 per-file *param_traits*.h=dcheng@chromium.org | 27 per-file *param_traits*.*=file://ipc/SECURITY_OWNERS |
| 48 per-file *param_traits*.h=inferno@chromium.org | |
| 49 per-file *param_traits*.h=jln@chromium.org | |
| 50 per-file *param_traits*.h=jschuh@chromium.org | |
| 51 per-file *param_traits*.h=kenrb@chromium.org | |
| 52 per-file *param_traits*.h=mkwst@chromium.org | |
| 53 per-file *param_traits*.h=nasko@chromium.org | |
| 54 per-file *param_traits*.h=palmer@chromium.org | |
| 55 per-file *param_traits*.h=tsepez@chromium.org | |
| 56 per-file *param_traits*.h=wfh@chromium.org | |
| 57 | 28 |
| 58 per-file *font_config_ipc_linux*=set noparent | 29 per-file *font_config_ipc_linux*=set noparent |
| 59 per-file *font_config_ipc_linux*=dcheng@chromium.org | 30 per-file *font_config_ipc_linux*=file://ipc/SECURITY_OWNERS |
| 60 per-file *font_config_ipc_linux*=inferno@chromium.org | |
| 61 per-file *font_config_ipc_linux*=jln@chromium.org | |
| 62 per-file *font_config_ipc_linux*=jschuh@chromium.org | |
| 63 per-file *font_config_ipc_linux*=kenrb@chromium.org | |
| 64 per-file *font_config_ipc_linux*=mkwst@chromium.org | |
| 65 per-file *font_config_ipc_linux*=nasko@chromium.org | |
| 66 per-file *font_config_ipc_linux*=palmer@chromium.org | |
| 67 per-file *font_config_ipc_linux*=tsepez@chromium.org | |
| 68 per-file *font_config_ipc_linux*=wfh@chromium.org | |
| 69 | 31 |
| 70 # Changes to Mojo interfaces require a security review to avoid | |
| 71 # introducing new sandbox escapes. | |
| 72 per-file *.mojom=set noparent | 32 per-file *.mojom=set noparent |
| 73 per-file *.mojom=dcheng@chromium.org | 33 per-file *.mojom=file://ipc/SECURITY_OWNERS |
| 74 per-file *.mojom=inferno@chromium.org | |
| 75 per-file *.mojom=jln@chromium.org | |
| 76 per-file *.mojom=jschuh@chromium.org | |
| 77 per-file *.mojom=kenrb@chromium.org | |
| 78 per-file *.mojom=mkwst@chromium.org | |
| 79 per-file *.mojom=nasko@chromium.org | |
| 80 per-file *.mojom=palmer@chromium.org | |
| 81 per-file *.mojom=tsepez@chromium.org | |
| 82 per-file *.mojom=wfh@chromium.org | |
| 83 | |
| 84 | 34 |
| 85 # Accessibility | 35 # Accessibility |
| 86 per-file accessibility_node_data.*=dmazzoni@chromium.org | 36 per-file accessibility_node_data.*=dmazzoni@chromium.org |
| 87 per-file accessibility_node_data.*=dtseng@chromium.org | 37 per-file accessibility_node_data.*=dtseng@chromium.org |
| 88 | 38 |
| 89 # WebSocket | 39 # WebSocket |
| 90 per-file websocket.*=ricea@chromium.org | 40 per-file websocket.*=ricea@chromium.org |
| 91 per-file websocket.*=tyoshino@chromium.org | 41 per-file websocket.*=tyoshino@chromium.org |
| 92 per-file websocket.*=yhirano@chromium.org | 42 per-file websocket.*=yhirano@chromium.org |
| 93 | 43 |
| 94 # DirectWrite | 44 # DirectWrite |
| 95 per-file dwrite_font_platform_win*=scottmg@chromium.org | 45 per-file dwrite_font_platform_win*=scottmg@chromium.org |
| 96 per-file font_warmup_win.cc=scottmg@chromium.org | 46 per-file font_warmup_win.cc=scottmg@chromium.org |
| OLD | NEW |
