Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 2070323002: Bug fix: android-run.py (Closed)

Created:
4 years, 6 months ago by Bangfu
Modified:
4 years, 5 months ago
CC:
ulan, v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Bug fix: android-run.py BUG= A bug in android-run.py, which caused the android_arm.release.check throws error: data/local/tmp/v8/test/mjsunit/wasm/function-prototype.js:7: Error loading file load("test/mjsunit/wasm/wasm-constants.js"); Committed: https://crrev.com/b8227914bcf822ff3f5abf627edb4cbab9be07f2 Cr-Commit-Position: refs/heads/master@{#37825}

Patch Set 1 : Error loading file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M tools/android-run.py View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 18 (8 generated)
Bangfu
On 2016/06/16 11:22:16, Bangfu wrote: > mailto:bangfu.tao@samsung.com changed reviewers: > + mailto:jochen@chromium.org, mailto:yangguo@google.com Hi, Please ...
4 years, 6 months ago (2016-06-16 11:24:35 UTC) #3
Yang
+Ulan LGTM.
4 years, 6 months ago (2016-06-16 11:51:48 UTC) #5
Bangfu
On 2016/06/16 11:51:48, Yang wrote: > +Ulan > > LGTM. Hi Jochen, Please review the ...
4 years, 6 months ago (2016-06-23 13:54:21 UTC) #7
jochen (gone - plz use gerrit)
lgtm
4 years, 5 months ago (2016-06-27 08:05:01 UTC) #8
ulan
lgtm
4 years, 5 months ago (2016-06-29 14:51:27 UTC) #10
Bangfu
On 2016/06/29 14:51:27, ulan wrote: > lgtm Please not forget to land the patch. Thanks.
4 years, 5 months ago (2016-07-18 08:31:04 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2070323002/1
4 years, 5 months ago (2016-07-18 08:31:49 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-18 09:42:31 UTC) #15
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-18 09:42:33 UTC) #16
commit-bot: I haz the power
4 years, 5 months ago (2016-07-18 09:45:33 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b8227914bcf822ff3f5abf627edb4cbab9be07f2
Cr-Commit-Position: refs/heads/master@{#37825}

Powered by Google App Engine
This is Rietveld 408576698