ui/gl/gl_version_info.cc - Issue 2070313002: Parse GL_VERSION incorrectly when version string is without release_number

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/gl/gl_version_info.cc

Issue 2070313002: Parse GL_VERSION incorrectly when version string is without release_number (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address zhenyao's comments Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/gl/gl_version_info.cc

diff --git a/ui/gl/gl_version_info.cc b/ui/gl/gl_version_info.cc

index cce2715b3703c60013a41cfb2ea8720eab4c14fc..07bc6bb76809fb35890efa17cbd53f7d2bd32a3e 100644

--- a/ui/gl/gl_version_info.cc

+++ b/ui/gl/gl_version_info.cc

@@ -73,7 +73,7 @@ void GLVersionInfo::ParseVersionString(const char* version_str,

*is_es = (lstr.length() > 12) && (lstr.substr(0, 9) == "opengl es");

if (*is_es)

lstr = lstr.substr(10, 3);

- base::StringTokenizer tokenizer(lstr.begin(), lstr.end(), ".");

+ base::StringTokenizer tokenizer(lstr.begin(), lstr.end(), ". ");

unsigned major, minor;

if (tokenizer.GetNext() &&

base::StringToUint(tokenizer.token_piece(), &major)) {

« no previous file with comments | « ui/gl/gl_tests.gyp ('k') | ui/gl/gl_version_info_unittest.cc » ('j') | ui/gl/gl_version_info_unittest.cc » ('J')