Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(770)

Unified Diff: ui/gl/gl_version_info.cc

Issue 2070313002: Parse GL_VERSION incorrectly when version string is without release_number (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/gl/gl_version_info.cc
diff --git a/ui/gl/gl_version_info.cc b/ui/gl/gl_version_info.cc
index cce2715b3703c60013a41cfb2ea8720eab4c14fc..07bc6bb76809fb35890efa17cbd53f7d2bd32a3e 100644
--- a/ui/gl/gl_version_info.cc
+++ b/ui/gl/gl_version_info.cc
@@ -73,7 +73,7 @@ void GLVersionInfo::ParseVersionString(const char* version_str,
*is_es = (lstr.length() > 12) && (lstr.substr(0, 9) == "opengl es");
if (*is_es)
lstr = lstr.substr(10, 3);
xinghua.cao 2016/06/16 10:29:05 If OpenGL version string is without release number
Ken Russell (switch to Gerrit) 2016/06/16 20:12:22 Thanks for tracking this down. Could you please c
- base::StringTokenizer tokenizer(lstr.begin(), lstr.end(), ".");
+ base::StringTokenizer tokenizer(lstr.begin(), lstr.end(), ". ");
unsigned major, minor;
if (tokenizer.GetNext() &&
base::StringToUint(tokenizer.token_piece(), &major)) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698