[Mac] Polish the search engine manager

[Mac] Polish the search engine manager

* Make the edit search engine window a sheet.
* Only allow one instance of the search engine manager to be opened at once.
* The search engine manager now remembers its position.
* Create NSWindow(LocalStateAdditions) category to assist with storing window
  position in Chromium's local state.

BUG=21761, 21762, 21883, 21996
TEST=Editing/adding a search engine happens in a sheet. Press [Manage] multiple times and only 1 window should open. Press [Manage] and the window should be at its last position.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=26646

[pink (ping after 24hrs), 2009-09-18 14:39:06]

Almost there, mostly concerned about the location of the pref registration.

http://codereview.chromium.org/207027/diff/1/4
File chrome/browser/cocoa/keyword_editor_cocoa_controller.mm (right):

http://codereview.chromium.org/207027/diff/1/4#newcode56
Line 56: + (void)initialize {
We have a global place where we register prefs, why not put it there? eg,
browser_prefs.cc

http://codereview.chromium.org/207027/diff/1/4#newcode110
Line 110: - (void)windowDidMove:(NSNotification*)notif {
what about if none of them ever move? Does this get called when they are
created? Why not do it when the window is closed?

http://codereview.chromium.org/207027/diff/1/6
File chrome/browser/cocoa/nswindow_local_state.mm (right):

http://codereview.chromium.org/207027/diff/1/6#newcode14
Line 14: DictionaryValue* windowPrefs = prefs->GetMutableDictionary(path);
can this return null?

[Robert Sesek, 2009-09-18 19:01:24]

http://codereview.chromium.org/207027/diff/1/4
File chrome/browser/cocoa/keyword_editor_cocoa_controller.mm (right):

http://codereview.chromium.org/207027/diff/1/4#newcode56
Line 56: + (void)initialize {
On 2009/09/18 14:39:06, pink wrote:
> We have a global place where we register prefs, why not put it there? eg,
> browser_prefs.cc

Done.

http://codereview.chromium.org/207027/diff/1/4#newcode110
Line 110: - (void)windowDidMove:(NSNotification*)notif {
On 2009/09/18 14:39:06, pink wrote:
> what about if none of them ever move? Does this get called when they are
> created? Why not do it when the window is closed?

The window is always moved when we restore the state because we call the cascade
method, so this is always hit. Just doing it on close would not have worked when
we allowed popping open of multiple windows.

http://codereview.chromium.org/207027/diff/1/6
File chrome/browser/cocoa/nswindow_local_state.mm (right):

http://codereview.chromium.org/207027/diff/1/6#newcode14
Line 14: DictionaryValue* windowPrefs = prefs->GetMutableDictionary(path);
On 2009/09/18 14:39:06, pink wrote:
> can this return null?

Not if it's registered with the PrefService (which it will be in
browser_prefs.cc).

[pink (ping after 24hrs), 2009-09-18 19:12:50]

LGTM

http://codereview.chromium.org/207027/diff/5001/5014
File chrome/browser/search_engines/keyword_editor_controller.cc (right):

http://codereview.chromium.org/207027/diff/5001/5014#newcode24
Line 24: // TODO(22269): Other platforms besides Mac should remember window
placement.
usually the format for this is:
// TODO(yourNameHere): blah blah blah. http://crbug.com/22269