Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1733)

Unified Diff: content/test/gpu/gpu_tests/webgl_conformance.py

Issue 2070233002: Output stacktraces on WebGL conformance failure. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/test/gpu/gpu_tests/webgl_conformance.py
diff --git a/content/test/gpu/gpu_tests/webgl_conformance.py b/content/test/gpu/gpu_tests/webgl_conformance.py
index 803b44ece243650210f800d54ddaf217c918d1b5..be917d7771dd4de0f997d376ee6a05f21b46458c 100644
--- a/content/test/gpu/gpu_tests/webgl_conformance.py
+++ b/content/test/gpu/gpu_tests/webgl_conformance.py
@@ -84,7 +84,11 @@ class WebglConformanceValidator(gpu_test_base.ValidatorBase):
def ValidateAndMeasurePage(self, page, tab, results):
if not _DidWebGLTestSucceed(tab):
- raise page_test.Failure(_WebGLTestMessages(tab))
+ is_valid_dump, trace_output = tab.browser.GetStackTrace()
Ken Russell (switch to Gerrit) 2016/06/16 17:48:01 I was concerned about the performance cost of doin
+ messages = _WebGLTestMessages(tab)
+ if is_valid_dump:
+ messages += '\nStack Trace:\n' + trace_output
+ raise page_test.Failure(messages)
def CustomizeBrowserOptions(self, options):
# --test-type=gpu is used only to suppress the "Google API Keys are missing"
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698