| OLD | NEW |
| 1 // Copyright 2016 The Chromium Authors. All rights reserved. | 1 // Copyright 2016 The Chromium Authors. All rights reserved. |
| 2 // Use of this source code is governed by a BSD-style license that can be | 2 // Use of this source code is governed by a BSD-style license that can be |
| 3 // found in the LICENSE file. | 3 // found in the LICENSE file. |
| 4 | 4 |
| 5 #include "net/cert/caching_cert_verifier.h" | 5 #include "net/cert/caching_cert_verifier.h" |
| 6 | 6 |
| 7 #include <memory> | 7 #include <memory> |
| 8 | 8 |
| 9 #include "base/files/file_path.h" | 9 #include "base/files/file_path.h" |
| 10 #include "base/memory/ptr_util.h" | 10 #include "base/memory/ptr_util.h" |
| 11 #include "base/memory/ref_counted.h" | 11 #include "base/memory/ref_counted.h" |
| 12 #include "net/base/net_errors.h" | 12 #include "net/base/net_errors.h" |
| 13 #include "net/base/test_completion_callback.h" | 13 #include "net/base/test_completion_callback.h" |
| 14 #include "net/base/test_data_directory.h" | 14 #include "net/base/test_data_directory.h" |
| 15 #include "net/cert/cert_trust_anchor_provider.h" | |
| 16 #include "net/cert/cert_verifier.h" | 15 #include "net/cert/cert_verifier.h" |
| 17 #include "net/cert/cert_verify_result.h" | 16 #include "net/cert/cert_verify_result.h" |
| 18 #include "net/cert/mock_cert_verifier.h" | 17 #include "net/cert/mock_cert_verifier.h" |
| 19 #include "net/cert/x509_certificate.h" | 18 #include "net/cert/x509_certificate.h" |
| 20 #include "net/log/net_log.h" | 19 #include "net/log/net_log.h" |
| 21 #include "net/test/cert_test_util.h" | 20 #include "net/test/cert_test_util.h" |
| 22 #include "testing/gmock/include/gmock/gmock.h" | 21 #include "testing/gmock/include/gmock/gmock.h" |
| 23 #include "testing/gtest/include/gtest/gtest.h" | 22 #include "testing/gtest/include/gtest/gtest.h" |
| 24 | 23 |
| 25 using testing::Mock; | 24 using testing::Mock; |
| 26 using testing::ReturnRef; | 25 using testing::ReturnRef; |
| 27 | 26 |
| 28 namespace net { | 27 namespace net { |
| 29 | 28 |
| 30 namespace { | |
| 31 | |
| 32 class MockCertTrustAnchorProvider : public CertTrustAnchorProvider { | |
| 33 public: | |
| 34 MockCertTrustAnchorProvider() {} | |
| 35 virtual ~MockCertTrustAnchorProvider() {} | |
| 36 | |
| 37 MOCK_METHOD0(GetAdditionalTrustAnchors, const CertificateList&()); | |
| 38 }; | |
| 39 | |
| 40 } // namespace | |
| 41 | |
| 42 class CachingCertVerifierTest : public ::testing::Test { | 29 class CachingCertVerifierTest : public ::testing::Test { |
| 43 public: | 30 public: |
| 44 CachingCertVerifierTest() : verifier_(base::MakeUnique<MockCertVerifier>()) {} | 31 CachingCertVerifierTest() : verifier_(base::MakeUnique<MockCertVerifier>()) {} |
| 45 ~CachingCertVerifierTest() override {} | 32 ~CachingCertVerifierTest() override {} |
| 46 | 33 |
| 47 protected: | 34 protected: |
| 48 CachingCertVerifier verifier_; | 35 CachingCertVerifier verifier_; |
| 49 }; | 36 }; |
| 50 | 37 |
| 51 TEST_F(CachingCertVerifierTest, CacheHit) { | 38 TEST_F(CachingCertVerifierTest, CacheHit) { |
| (...skipping 78 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
| 130 error = callback.GetResult(verifier_.Verify( | 117 error = callback.GetResult(verifier_.Verify( |
| 131 CertVerifier::RequestParams(cert_chain2, "www.example.com", 0, | 118 CertVerifier::RequestParams(cert_chain2, "www.example.com", 0, |
| 132 std::string(), CertificateList()), | 119 std::string(), CertificateList()), |
| 133 nullptr, &verify_result, callback.callback(), &request, BoundNetLog())); | 120 nullptr, &verify_result, callback.callback(), &request, BoundNetLog())); |
| 134 ASSERT_TRUE(IsCertificateError(error)); | 121 ASSERT_TRUE(IsCertificateError(error)); |
| 135 ASSERT_EQ(2u, verifier_.requests()); | 122 ASSERT_EQ(2u, verifier_.requests()); |
| 136 ASSERT_EQ(0u, verifier_.cache_hits()); | 123 ASSERT_EQ(0u, verifier_.cache_hits()); |
| 137 ASSERT_EQ(2u, verifier_.GetCacheSize()); | 124 ASSERT_EQ(2u, verifier_.GetCacheSize()); |
| 138 } | 125 } |
| 139 | 126 |
| 140 TEST_F(CachingCertVerifierTest, CertTrustAnchorProvider) { | |
| 141 MockCertTrustAnchorProvider trust_provider; | |
| 142 verifier_.SetCertTrustAnchorProvider(&trust_provider); | |
| 143 | |
| 144 scoped_refptr<X509Certificate> test_cert( | |
| 145 ImportCertFromFile(GetTestCertsDirectory(), "ok_cert.pem")); | |
| 146 ASSERT_TRUE(test_cert.get()); | |
| 147 | |
| 148 const CertificateList empty_cert_list; | |
| 149 CertificateList cert_list; | |
| 150 cert_list.push_back(test_cert); | |
| 151 | |
| 152 // Check that Verify() asks the |trust_provider| for the current list of | |
| 153 // additional trust anchors. | |
| 154 int error; | |
| 155 CertVerifyResult verify_result; | |
| 156 TestCompletionCallback callback; | |
| 157 std::unique_ptr<CertVerifier::Request> request; | |
| 158 EXPECT_CALL(trust_provider, GetAdditionalTrustAnchors()) | |
| 159 .WillOnce(ReturnRef(empty_cert_list)); | |
| 160 error = callback.GetResult(verifier_.Verify( | |
| 161 CertVerifier::RequestParams(test_cert, "www.example.com", 0, | |
| 162 std::string(), CertificateList()), | |
| 163 nullptr, &verify_result, callback.callback(), &request, BoundNetLog())); | |
| 164 Mock::VerifyAndClearExpectations(&trust_provider); | |
| 165 EXPECT_TRUE(IsCertificateError(error)); | |
| 166 ASSERT_EQ(1u, verifier_.requests()); | |
| 167 ASSERT_EQ(0u, verifier_.cache_hits()); | |
| 168 | |
| 169 // The next Verify() uses the cached result. | |
| 170 EXPECT_CALL(trust_provider, GetAdditionalTrustAnchors()) | |
| 171 .WillOnce(ReturnRef(empty_cert_list)); | |
| 172 error = callback.GetResult(verifier_.Verify( | |
| 173 CertVerifier::RequestParams(test_cert, "www.example.com", 0, | |
| 174 std::string(), CertificateList()), | |
| 175 nullptr, &verify_result, callback.callback(), &request, BoundNetLog())); | |
| 176 Mock::VerifyAndClearExpectations(&trust_provider); | |
| 177 EXPECT_TRUE(IsCertificateError(error)); | |
| 178 ASSERT_EQ(2u, verifier_.requests()); | |
| 179 ASSERT_EQ(1u, verifier_.cache_hits()); | |
| 180 | |
| 181 // Another Verify() for the same certificate but with a different list of | |
| 182 // trust anchors will not reuse the cache. | |
| 183 EXPECT_CALL(trust_provider, GetAdditionalTrustAnchors()) | |
| 184 .WillOnce(ReturnRef(cert_list)); | |
| 185 error = callback.GetResult(verifier_.Verify( | |
| 186 CertVerifier::RequestParams(test_cert, "www.example.com", 0, | |
| 187 std::string(), CertificateList()), | |
| 188 nullptr, &verify_result, callback.callback(), &request, BoundNetLog())); | |
| 189 Mock::VerifyAndClearExpectations(&trust_provider); | |
| 190 EXPECT_TRUE(IsCertificateError(error)); | |
| 191 ASSERT_EQ(3u, verifier_.requests()); | |
| 192 ASSERT_EQ(1u, verifier_.cache_hits()); | |
| 193 } | |
| 194 | |
| 195 } // namespace net | 127 } // namespace net |
| OLD | NEW |