Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2070213002:
Promises: Add regression test for promise resolution with proxy (Closed)
|
Created:
4 years, 6 months ago by gsathya Modified:
4 years, 6 months ago Reviewers:
Dan Ehrenberg CC:
v8-reviews_googlegroups.com Base URL:
https://chromium.googlesource.com/v8/v8.git@master Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
DescriptionPromises: Add regression test for promise resolution with proxy
BUG=v8:5004
Committed: https://crrev.com/3624a5e110f67136485de17de465719384498066
Cr-Commit-Position: refs/heads/master@{#37015}
Patch Set 1 #Patch Set 2 : add regression test #
Total comments: 1
Messages
Total messages: 17 (8 generated)
Description was changed from ========== Promises: Add regression test for promise resolution with proxy BUG=v8:5004 ========== to ========== Promises: Add regression test for promise resolution with proxy R=littledan@chromium.org BUG=v8:5004 ==========
The CQ bit was checked by gsathya@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2070213002/20001
Description was changed from ========== Promises: Add regression test for promise resolution with proxy R=littledan@chromium.org BUG=v8:5004 ========== to ========== Promises: Add regression test for promise resolution with proxy BUG=v8:5004 ==========
gsathya@chromium.org changed reviewers: + littledan@chromium.org
https://codereview.chromium.org/2070213002/diff/20001/test/mjsunit/regress/re... File test/mjsunit/regress/regress-5004.js (right): https://codereview.chromium.org/2070213002/diff/20001/test/mjsunit/regress/re... test/mjsunit/regress/regress-5004.js:27: p.key.then(v => assertAsync(v === 20)); Are you sure this will be enough without %RunMicrotasks?
On 2016/06/16 00:38:47, Dan Ehrenberg wrote: > https://codereview.chromium.org/2070213002/diff/20001/test/mjsunit/regress/re... > File test/mjsunit/regress/regress-5004.js (right): > > https://codereview.chromium.org/2070213002/diff/20001/test/mjsunit/regress/re... > test/mjsunit/regress/regress-5004.js:27: p.key.then(v => assertAsync(v === 20)); > Are you sure this will be enough without %RunMicrotasks? Yeah, works fine without %RunMicrotasks. The problem before was that I was calling %AbortJS(v), but %AbortJS only takes in a string, so it threw an exception which was silently ignored.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by gsathya@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2070213002/20001
Message was sent while issue was closed.
Description was changed from ========== Promises: Add regression test for promise resolution with proxy BUG=v8:5004 ========== to ========== Promises: Add regression test for promise resolution with proxy BUG=v8:5004 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Promises: Add regression test for promise resolution with proxy BUG=v8:5004 ========== to ========== Promises: Add regression test for promise resolution with proxy BUG=v8:5004 Committed: https://crrev.com/3624a5e110f67136485de17de465719384498066 Cr-Commit-Position: refs/heads/master@{#37015} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/3624a5e110f67136485de17de465719384498066 Cr-Commit-Position: refs/heads/master@{#37015} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
