Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(432)

Unified Diff: ash/wm/system_modal_container_layout_manager.h

Issue 2070163002: Fix "modal isn't modal in multi displays" issue (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Modal fix Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/wm/system_modal_container_layout_manager.h
diff --git a/ash/wm/system_modal_container_layout_manager.h b/ash/wm/system_modal_container_layout_manager.h
index be35747b0be07be361b48e863ed53e2cf0274acc..19d6319c82fd61126eb35c4d68e837565469e1ad 100644
--- a/ash/wm/system_modal_container_layout_manager.h
+++ b/ash/wm/system_modal_container_layout_manager.h
@@ -54,8 +54,9 @@ class ASH_EXPORT SystemModalContainerLayoutManager
// Overridden from keyboard::KeyboardControllerObserver:
void OnKeyboardBoundsChanging(const gfx::Rect& new_bounds) override;
- // Can a given |window| receive and handle input events?
- bool CanWindowReceiveEvents(aura::Window* window);
+ // True if the window is either contianed by the top most modal window,
James Cook 2016/06/16 20:31:35 nit: "contained"
oshima 2016/06/17 00:06:12 Done.
+ // or contained by its transient children.
+ bool IsActiveModalWindows(aura::Window* window);
James Cook 2016/06/16 20:31:36 nit: maybe IsActiveModalWindow() singular?
oshima 2016/06/17 00:06:12 There can be multiple windows that are part of act
James Cook 2016/06/17 16:04:43 IsPartOfActiveModalWindow() sounds good.
oshima 2016/06/18 09:21:44 Done.
// Activates next modal window if any. Returns false if there
// are no more modal windows in this layout manager.

Powered by Google App Engine
This is Rietveld 408576698