Add an experimental flag for offlining.

Add an experimental flag for offlining.

BUG=620421
Committed: https://crrev.com/54fd4951328e78a93e0cb928e0063e2197538fa2
Cr-Commit-Position: refs/heads/master@{#400462}

[dewittj, 2016-06-15 23:06:06]

dewittj@chromium.org changed reviewers:
+ jianli@chromium.org

[jianli, 2016-06-15 23:28:50]

You will also need to update OfflinePageBridge.java

https://codereview.chromium.org/2070153002/diff/20001/chrome/browser/android/...
File chrome/browser/android/chrome_feature_list.cc (right):

https://codereview.chromium.org/2070153002/diff/20001/chrome/browser/android/...
chrome/browser/android/chrome_feature_list.cc:42:
&offline_pages::kOfflineExperimentalFeature,
Don't add this unless you need to check this directly in Java code.

https://codereview.chromium.org/2070153002/diff/20001/components/offline_page...
File components/offline_pages/offline_page_feature.cc (right):

https://codereview.chromium.org/2070153002/diff/20001/components/offline_page...
components/offline_pages/offline_page_feature.cc:31:
IsOfflinePagesBackgroundLoadingEnabled();
Add the check here.

[fgorski, 2016-06-16 13:54:25]

fgorski@chromium.org changed reviewers:
+ fgorski@chromium.org

[fgorski, 2016-06-16 13:54:26]

Justin, all flags are experimental. Could you name it a little better so that it
refers to cct or something else this experiment is about?

[dewittj, 2016-06-16 18:37:58]

On 2016/06/16 13:54:26, fgorski wrote:
> Justin, all flags are experimental. Could you name it a little better so that
it
> refers to cct or something else this experiment is about?

Renamed.  Also referenced tracking bug in offline_page_feature.h. PTAL.

[dewittj, 2016-06-16 18:38:07]

https://codereview.chromium.org/2070153002/diff/20001/chrome/browser/android/...
File chrome/browser/android/chrome_feature_list.cc (right):

https://codereview.chromium.org/2070153002/diff/20001/chrome/browser/android/...
chrome/browser/android/chrome_feature_list.cc:42:
&offline_pages::kOfflineExperimentalFeature,
On 2016/06/15 23:28:49, jianli wrote:
> Don't add this unless you need to check this directly in Java code.

Acknowledged.  See bug.

https://codereview.chromium.org/2070153002/diff/20001/components/offline_page...
File components/offline_pages/offline_page_feature.cc (right):

https://codereview.chromium.org/2070153002/diff/20001/components/offline_page...
components/offline_pages/offline_page_feature.cc:31:
IsOfflinePagesBackgroundLoadingEnabled();
On 2016/06/15 23:28:49, jianli wrote:
> Add the check here.

Done.

[fgorski, 2016-06-16 19:01:29]

lgtm I like the renamed flag. Thanks!

[dewittj, 2016-06-16 19:28:29]

Description was changed from

==========
Add an experimental flag for offlining.

BUG=620421
==========

to

==========
Add an experimental flag for offlining.

BUG=620421
==========

[dewittj, 2016-06-16 19:28:29]

dewittj@chromium.org changed reviewers:
+ tedchoc@chromium.org

[dewittj, 2016-06-16 19:29:10]

tedchoc: ptal at chrome/browser/android

[jianli, 2016-06-16 21:53:38]

lgtm

"ct" in the feature name sounds a bit unclear. Will it be better if we can use
non-abbreviation form?

https://codereview.chromium.org/2070153002/diff/60001/chrome/app/generated_re...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/2070153002/diff/60001/chrome/app/generated_re...
chrome/app/generated_resources.grd:14968: +        Enable Offline Pages CT
features. Requires Offline Pages to be enabled.
nit: remove "Requires Offline Pages to be enabled."

[Ted C, 2016-06-16 22:50:02]

On 2016/06/16 21:53:38, jianli wrote:
> lgtm
> 
> "ct" in the feature name sounds a bit unclear. Will it be better if we can use
> non-abbreviation form?
> 
>
https://codereview.chromium.org/2070153002/diff/60001/chrome/app/generated_re...
> File chrome/app/generated_resources.grd (right):
> 
>
https://codereview.chromium.org/2070153002/diff/60001/chrome/app/generated_re...
> chrome/app/generated_resources.grd:14968: +        Enable Offline Pages CT
> features. Requires Offline Pages to be enabled.
> nit: remove "Requires Offline Pages to be enabled."

lgtm - chrome/browser/android/chrome_feature_list.cc

[dewittj, 2016-06-17 17:30:03]

The CQ bit was checked by dewittj@chromium.org

[dewittj, 2016-06-17 17:30:04]

The patchset sent to the CQ was uploaded after l-g-t-m from
tedchoc@chromium.org, jianli@chromium.org, fgorski@chromium.org
Link to the patchset: https://codereview.chromium.org/2070153002/#ps80001
(title: "remove copy pasted desription.")

[commit-bot: I haz the power, 2016-06-17 17:30:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2070153002/80001

[commit-bot: I haz the power, 2016-06-17 18:25:41]

Description was changed from

==========
Add an experimental flag for offlining.

BUG=620421
==========

to

==========
Add an experimental flag for offlining.

BUG=620421
==========

[commit-bot: I haz the power, 2016-06-17 18:25:42]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-06-17 18:27:41]

Description was changed from

==========
Add an experimental flag for offlining.

BUG=620421
==========

to

==========
Add an experimental flag for offlining.

BUG=620421

Committed: https://crrev.com/54fd4951328e78a93e0cb928e0063e2197538fa2
Cr-Commit-Position: refs/heads/master@{#400462}
==========

[commit-bot: I haz the power, 2016-06-17 18:27:42]

Patchset 5 (id:??) landed as
https://crrev.com/54fd4951328e78a93e0cb928e0063e2197538fa2
Cr-Commit-Position: refs/heads/master@{#400462}