Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(330)

Unified Diff: chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc

Issue 2070143003: Add MD ink drop ripple to app list button (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@b612539_shelf_button_ripple
Patch Set: Rebased Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc
diff --git a/chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc b/chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc
index 8a9dcd0f7d87ca21d709f5c10266a4c8753ccb67..7c80591f5e68abd0851dd5b088c08b3b8196d992 100644
--- a/chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc
+++ b/chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc
@@ -206,7 +206,7 @@ class BookmarkButtonBase : public views::LabelButton {
: LabelButton(listener, title) {
SetElideBehavior(kElideBehavior);
if (ui::MaterialDesignController::IsModeMaterial()) {
- SetHasInkDrop(true);
+ SetInkDropMode(InkDropMode::ON);
set_has_ink_drop_action_on_click(true);
SetFocusPainter(nullptr);
}
@@ -335,9 +335,10 @@ class BookmarkMenuButtonBase : public views::MenuButton {
views::MenuButtonListener* menu_button_listener,
bool show_menu_marker)
: MenuButton(title, menu_button_listener, show_menu_marker) {
- SetHasInkDrop(ui::MaterialDesignController::IsModeMaterial());
- if (ui::MaterialDesignController::IsModeMaterial())
+ if (ui::MaterialDesignController::IsModeMaterial()) {
+ SetInkDropMode(InkDropMode::ON);
SetFocusPainter(nullptr);
+ }
}
std::unique_ptr<views::InkDropRipple> CreateInkDropRipple() const override {
« no previous file with comments | « chrome/browser/ui/views/bar_control_button.cc ('k') | chrome/browser/ui/views/download/download_item_view_md.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698