chrome/browser/ui/views/download/download_item_view_md.cc - Issue 2070143003: Add MD ink drop ripple to app list button

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/download/download_item_view_md.cc

Issue 2070143003: Add MD ink drop ripple to app list button (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@b612539_shelf_button_ripple

Patch Set: Changed SetHasInkDrop to SetInkDropMode Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc ('k') | chrome/browser/ui/views/location_bar/bubble_icon_view.cc » ('j') | ui/views/animation/ink_drop_host_view.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/download/download_item_view_md.cc

diff --git a/chrome/browser/ui/views/download/download_item_view_md.cc b/chrome/browser/ui/views/download/download_item_view_md.cc

index 9ebf09d1f404ff7cf418045cf97ce4638ddc0e3f..7e04ac9e9072ac03650df6ef23d154b384f4844f 100644

--- a/chrome/browser/ui/views/download/download_item_view_md.cc

+++ b/chrome/browser/ui/views/download/download_item_view_md.cc

@@ -187,7 +187,8 @@ DownloadItemViewMd::DownloadItemViewMd(DownloadItem* download_item,

creation_time_(base::Time::Now()),

time_download_warning_shown_(base::Time()),

weak_ptr_factory_(this) {

- SetHasInkDrop(ui::MaterialDesignController::IsModeMaterial());

+ if (ui::MaterialDesignController::IsModeMaterial())

sky 2016/06/30 00:35:34 This class is only created when in md, so you can

mohsen 2016/06/30 08:54:07 Done.

+ SetInkDropMode(INK_DROP_WITH_GESTURE_HANDLING);

DCHECK(download());

DCHECK(ui::MaterialDesignController::IsModeMaterial());

download()->AddObserver(this);