Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Unified Diff: chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc

Issue 2070143003: Add MD ink drop ripple to app list button (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@b612539_shelf_button_ripple
Patch Set: Addressed review comments Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc
diff --git a/chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc b/chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc
index 7199f4496b7b7f745b9ed20aedcfb44e112363a0..72186c3a17181c21e729b149a0f5d8e30e9d0e0e 100644
--- a/chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc
+++ b/chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc
@@ -205,7 +205,8 @@ class BookmarkButtonBase : public views::LabelButton {
const base::string16& title)
: LabelButton(listener, title) {
SetElideBehavior(kElideBehavior);
- SetHasInkDrop(ui::MaterialDesignController::IsModeMaterial());
+ if (ui::MaterialDesignController::IsModeMaterial())
+ SetHasInkDrop(INK_DROP_WITH_GESTURE_HANDLING);
set_has_ink_drop_action_on_click(true);
show_animation_.reset(new gfx::SlideAnimation(this));
if (!animations_enabled) {
@@ -331,7 +332,8 @@ class BookmarkMenuButtonBase : public views::MenuButton {
views::MenuButtonListener* menu_button_listener,
bool show_menu_marker)
: MenuButton(title, menu_button_listener, show_menu_marker) {
- SetHasInkDrop(ui::MaterialDesignController::IsModeMaterial());
+ if (ui::MaterialDesignController::IsModeMaterial())
+ SetHasInkDrop(INK_DROP_WITH_GESTURE_HANDLING);
}
std::unique_ptr<views::InkDropRipple> CreateInkDropRipple() const override {

Powered by Google App Engine
This is Rietveld 408576698