ash/sysui/app_list_presenter_mus.cc - Issue 2070143003: Add MD ink drop ripple to app list button

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/sysui/app_list_presenter_mus.cc

Issue 2070143003: Add MD ink drop ripple to app list button (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@b612539_shelf_button_ripple

Patch Set: Added tests + Addressed review comments Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« ash/shelf/shelf_view_unittest.cc ('K') | « ash/sysui/app_list_presenter_mus.h ('k') | chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_browsertest.cc » ('j') | ui/views/controls/button/custom_button.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ash/sysui/app_list_presenter_mus.cc

diff --git a/ash/sysui/app_list_presenter_mus.cc b/ash/sysui/app_list_presenter_mus.cc

index 5fe60b76111b0c50eb41f9834ea6797ec8d95e57..fb86591de19a5e2d7e49285de6360d84375009e3 100644

--- a/ash/sysui/app_list_presenter_mus.cc

+++ b/ash/sysui/app_list_presenter_mus.cc

@@ -45,6 +45,10 @@ void AppListPresenterMus::ToggleAppList(int64_t display_id) {

presenter_->ToggleAppList(display_id);

}

+bool AppListPresenterMus::IsVisible() const {

+ return false;

bool AppListPresenterMus::GetTargetVisibility() const {

// TODO(mfomitchev): we have GetTargetVisibility() in mojom, but this

// shouldn't be a synchronous method. We should go through the call sites and