Add MD ink drop ripple to app list button

ui/views/animation/ink_drop_host_view.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef UI_VIEWS_ANIMATION_INK_DROP_HOST_VIEW_H_
 #define UI_VIEWS_ANIMATION_INK_DROP_HOST_VIEW_H_
 
 #include <memory>
 
 #include "third_party/skia/include/core/SkColor.h"
@@ skipping 20 matching lines @@
 
   // Overridden from InkDropHost:
   void AddInkDropLayer(ui::Layer* ink_drop_layer) override;
   void RemoveInkDropLayer(ui::Layer* ink_drop_layer) override;
   std::unique_ptr<InkDropRipple> CreateInkDropRipple() const override;
   std::unique_ptr<InkDropHighlight> CreateInkDropHighlight() const override;
 
   void set_ink_drop_size(const gfx::Size& size) { ink_drop_size_ = size; }
 
  protected:
+  // Used in SetInkDropMode() to specify whether the ink drop effect is enabled
+  // or not for the view. In case of having an ink drop, it also specifies
+  // whether the default gesture event handler for the ink drop should be
+  // installed or the subclass will handle gesture events itself.
+  enum InkDropMode {
+    NO_INK_DROP,
+    INK_DROP_WITHOUT_GESTURE_HANDLING,
+    INK_DROP_WITH_GESTURE_HANDLING,

[sky, 2016/06/30 00:35:34]

Sorry, one concern I have in looking at the changes to supporting code is that
it isn't clear why any of the code wants gesture handling. My concern is just
the naming, I think if INK_DROP_WITHOUT_GESTURE_HANDLING was named INK_DROP_ON
(or InkDropMode::ON) it would be easier to understand and
InkDropMode::ON_NO_GESTURE_HANDLER for the outliers.
Another option is to keep the boolean and instead have an explicit
SetIsGestureHandlingEnabled() to turn on/off the gesture handling. I actually
might go for that. WDYT?

[mohsen, 2016/06/30 08:54:07]

Having two separate functions makes the code a bit complicated. First,
SetIsGestureHandlingEnabled() is not meaningful if ink drop is not enabled.
Second, they can probably be called in any order which might be unnecessarily
difficult to handle; especially that currently the difference between ink drop
being enabled vs. disabled is having an instance of InkDropImpl vs. InkDropStub.
This default gesture handler is also something that we are considering getting
rid of (see TODO above its definition in ink_drop_host_view.cc). All in all, I
think this approach is not worth its complexity. So, I opted for your first
suggestion of renaming enum values to OFF, ON, ON_NO_GESTURE_HANDLER.

+  };
+
   static const int kInkDropSmallCornerRadius;
 
   void set_ink_drop_visible_opacity(float visible_opacity) {
     ink_drop_visible_opacity_ = visible_opacity;
   }
   float ink_drop_visible_opacity() const { return ink_drop_visible_opacity_; }
 
   // Returns the default InkDropRipple centered on |center_point|.
   std::unique_ptr<InkDropRipple> CreateDefaultInkDropRipple(
       const gfx::Point& center_point) const;
@@ skipping 26 matching lines @@
   virtual SkColor GetInkDropBaseColor() const;
 
   // Should return true if the ink drop is also used to depict focus.
   virtual bool ShouldShowInkDropForFocus() const;
 
   InkDrop* ink_drop() { return ink_drop_.get(); }
 
   // Toggle to enable/disable an InkDrop on this View.  Descendants can override
   // CreateInkDropHighlight() and CreateInkDropRipple() to change the look/feel
   // of the InkDrop.
-  void SetHasInkDrop(bool has_an_ink_drop);
+  void SetInkDropMode(InkDropMode ink_drop_mode);
 
  private:
   class InkDropGestureHandler;
   friend class InkDropGestureHandler;
   friend class test::InkDropHostViewTestApi;
 
   // The last user Event to trigger an ink drop ripple animation.
   std::unique_ptr<ui::LocatedEvent> last_ripple_triggering_event_;
 
   std::unique_ptr<InkDrop> ink_drop_;
@@ skipping 10 matching lines @@
   // drop layer.
   bool old_paint_to_layer_;
 
   bool destroying_;
 
   DISALLOW_COPY_AND_ASSIGN(InkDropHostView);
 };
 }  // namespace views
 
 #endif  // UI_VIEWS_ANIMATION_INK_DROP_HOST_VIEW_H_