Workaround for Issue 15949: cannot use the "WenQuanYi Bitmap Song" (chinese F...

Workaround for Issue 15949: cannot use the "WenQuanYi Bitmap Song" (chinese Fonts) as the system fonts with chrome

- Adding a font fallback code to Font::CreateFont() in font_skia.cc so that Chromium can startup even when a non-scalable font is selected as an application font. If the application font is non-scalable, Font::CreateFont() loads a _scalable_ "sans" font as a fallback.
  (Note: The function still never load non-scalable fonts.)
- Removed a comment for issue 12530 since the issue has been fixed.

BUG=12530
BUG=15949
TEST=Download the snap.pcf font from http://artwizaleczapka.sourceforge.net/ and put it to ~/.fonts/. Remove temporarily /etc/fonts/conf.d/70-no-bitmaps.conf and run "fc-cache -f". Start /ust/bin/gnome-appearance-properties and select "snap" as your application font. Then start chromium and verify that it does not crash (by the CHECK failure) on startup.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=26652

[Yusuke Sato, 2009-09-17 06:17:05]

agl:
Could you review this?

sky:
If you're planning to nuke the file, font_skia.cc, to fix Issue 20823, please
let me know. I'll take back this change.

--Yusuke

[sky, 2009-09-17 15:27:26]

I would like to nuke font_skia, but using pango directly incurs at best a 10%
startup hit. As such, we're sticking with font_skia. I'll send a writeup around
shortly.

  -Scott

On 2009/09/17 06:17:05, Yusuke Sato wrote:
> agl:
> Could you review this?
> 
> sky:
> If you're planning to nuke the file, font_skia.cc, to fix Issue 20823, please
> let me know. I'll take back this change.
> 
> --Yusuke

[Yusuke Sato, 2009-09-18 03:53:08]

Thanks for the writeup. So, I think this patch does not conflict with your plan
for the time being. Please take another look.

--Yusuke

[sky, 2009-09-18 13:52:36]

LGTM as long as you convert from wchar_t to char.

http://codereview.chromium.org/207009/diff/2001/2002
File app/gfx/font_skia.cc (right):

http://codereview.chromium.org/207009/diff/2001/2002#newcode20
Line 20: const wchar_t* kFallbackFontFamilyName = L"sans";
make this as char* as the function you call takes UTF8.

[Yusuke Sato, 2009-09-18 15:30:01]

Thanks for the review.

http://codereview.chromium.org/207009/diff/2001/2002
File app/gfx/font_skia.cc (right):

http://codereview.chromium.org/207009/diff/2001/2002#newcode20
Line 20: const wchar_t* kFallbackFontFamilyName = L"sans";
On 2009/09/18 13:52:36, sky wrote:
> make this as char* as the function you call takes UTF8.

Done.