Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 2070083003: Revert of Remove all the @FlakyTest annotations in ImeTest (Closed)

Created:
4 years, 6 months ago by Henrik Grunell
Modified:
4 years, 6 months ago
Reviewers:
yabinh, Changwan Ryu
CC:
aelias_OOO_until_Jul13
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Remove all the @FlakyTest annotations in ImeTest (patchset #2 id:20001 of https://codereview.chromium.org/2058633004/ ) Reason for revert: Flaky failure seen in https://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/34878 Original issue's description: > There are 6 flaky tests in ImeTest. They are flaky because when we call > InputConnection#setSelection and other methods together, the order of messages > sometimes does not get kept. > > We can solve this by enabling IME thread, because when IME thead is on, > the order can be kept. > > Another way is applying the following patch, which deals with the re-ordering > issue: https://codereview.chromium.org/1877073003/. Since the patch has been > landed, we can remove the @FlakyTest annotations. > > BUG=598482, 603991 > > Committed: https://crrev.com/6f23392b1f1f2b91909f646bc5ddf54c2c4003a6 > Cr-Commit-Position: refs/heads/master@{#400099} TBR=changwan@chromium.org,yabinh@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=598482, 603991 Committed: https://crrev.com/186c15876ee97b4d0be6302c0635814c873448f5 Cr-Commit-Position: refs/heads/master@{#400151}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java View 7 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Henrik Grunell
Created Revert of Remove all the @FlakyTest annotations in ImeTest
4 years, 6 months ago (2016-06-16 14:20:39 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2070083003/1
4 years, 6 months ago (2016-06-16 14:20:53 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-16 14:21:28 UTC) #5
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-16 14:21:34 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-16 14:22:54 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/186c15876ee97b4d0be6302c0635814c873448f5
Cr-Commit-Position: refs/heads/master@{#400151}

Powered by Google App Engine
This is Rietveld 408576698