Enable do not allow default action for untrusted events.

Enable do not allow default action for untrusted events.

Approved intent to ship: https://groups.google.com/a/chromium.org/d/msg/blink-dev/WEMnlVIbe70/i2MJcEtNBgAJ

BUG=565760, 423975, 520519
Committed: https://crrev.com/887e8fba784c801afbda06799a99284421408ff1
Cr-Commit-Position: refs/heads/master@{#401463}

[dtapuska, 2016-06-17 08:37:52]

Description was changed from

==========
Enable do not allow default action for untrusted events.

Approved intent to ship:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/OzHI2c2vkEo/9Bz-j4Ph...

BUG=565760,423975,520519
==========

to

==========
Enable do not allow default action for untrusted events.

Approved intent to ship:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/OzHI2c2vkEo/9Bz-j4Ph...

CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux
BUG=565760,423975,520519
==========

[dtapuska, 2016-06-21 20:13:08]

Description was changed from

==========
Enable do not allow default action for untrusted events.

Approved intent to ship:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/OzHI2c2vkEo/9Bz-j4Ph...

CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux
BUG=565760,423975,520519
==========

to

==========
Enable do not allow default action for untrusted events.

Approved intent to ship:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/OzHI2c2vkEo/9Bz-j4Ph...

CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation;tryserver.chromium.linux
BUG=565760,423975,520519
==========

[dtapuska, 2016-06-22 17:56:23]

Description was changed from

==========
Enable do not allow default action for untrusted events.

Approved intent to ship:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/OzHI2c2vkEo/9Bz-j4Ph...

CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation;tryserver.chromium.linux
BUG=565760,423975,520519
==========

to

==========
Enable do not allow default action for untrusted events.

Approved intent to ship:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/OzHI2c2vkEo/9Bz-j4Ph...

CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation;tryserver.chromium.linux
BUG=565760,423975,520519
==========

[dtapuska, 2016-06-22 17:56:24]

dtapuska@chromium.org changed reviewers:
+ rbyers@chromium.org

[dtapuska, 2016-06-22 17:56:48]

PTAL; I believe I have landed all the dependent fixes to make this a simple
patch.

[Rick Byers, 2016-06-22 18:32:20]

Description was changed from

==========
Enable do not allow default action for untrusted events.

Approved intent to ship:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/OzHI2c2vkEo/9Bz-j4Ph...

CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation;tryserver.chromium.linux
BUG=565760,423975,520519
==========

to

==========
Enable do not allow default action for untrusted events.

Approved intent to ship:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/WEMnlVIbe70

CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation;tryserver.chromium.linux
BUG=565760,423975,520519
==========

[Rick Byers, 2016-06-22 18:32:39]

On 2016/06/22 17:56:48, dtapuska wrote:
> PTAL; I believe I have landed all the dependent fixes to make this a simple
> patch.

Updated CL description with the right intent thread.

[dtapuska, 2016-06-22 18:33:56]

Description was changed from

==========
Enable do not allow default action for untrusted events.

Approved intent to ship:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/WEMnlVIbe70

CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation;tryserver.chromium.linux
BUG=565760,423975,520519
==========

to

==========
Enable do not allow default action for untrusted events.

Approved intent to ship:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/WEMnlVIbe70/i2MJcEtN...

CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation;tryserver.chromium.linux
BUG=565760,423975,520519
==========

[Rick Byers, 2016-06-22 18:57:26]

Looks good, just one little concern / question.

https://codereview.chromium.org/2070053004/diff/100001/third_party/WebKit/Lay...
File third_party/WebKit/LayoutTests/plugins/user-gesture.html (right):

https://codereview.chromium.org/2070053004/diff/100001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/plugins/user-gesture.html:8: mousedown/mouseup
event pair is a user gesture, and the second is not.
This comment is now wrong, right?

Are untrusted input events not sent to plugins at all?  Could be a compat issue
to watch out for...

[dtapuska, 2016-06-22 19:10:35]

https://codereview.chromium.org/2070053004/diff/100001/third_party/WebKit/Lay...
File third_party/WebKit/LayoutTests/plugins/user-gesture.html (right):

https://codereview.chromium.org/2070053004/diff/100001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/plugins/user-gesture.html:8: mousedown/mouseup
event pair is a user gesture, and the second is not.
On 2016/06/22 18:57:26, Rick Byers wrote:
> This comment is now wrong, right?
> 
> Are untrusted input events not sent to plugins at all?  Could be a compat
issue
> to watch out for...

Done. This is captured in our UMA metrics tracking because the events are fired
to the plugin widget via the defaultEventHandler. (See
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/html/HTML...)

[Rick Byers, 2016-06-22 21:20:07]

LGTM

[dtapuska, 2016-06-22 21:25:32]

The CQ bit was checked by dtapuska@chromium.org

[commit-bot: I haz the power, 2016-06-22 21:26:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2070053004/120001

[commit-bot: I haz the power, 2016-06-22 21:26:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-22 21:26:50]

Transient error: Invalid delimiter in "tryserver.chromium.linux":
Correct syntax is "tryserver:bot1,bot2;tryserver2:bot3,bot4;".

[dtapuska, 2016-06-22 22:07:50]

The CQ bit was checked by dtapuska@chromium.org

[commit-bot: I haz the power, 2016-06-22 22:08:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2070053004/120001

[commit-bot: I haz the power, 2016-06-22 22:08:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-22 22:08:24]

Transient error: Invalid delimiter in "tryserver.chromium.linux":
Correct syntax is "tryserver:bot1,bot2;tryserver2:bot3,bot4;".

[dtapuska, 2016-06-22 22:11:03]

Description was changed from

==========
Enable do not allow default action for untrusted events.

Approved intent to ship:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/WEMnlVIbe70/i2MJcEtN...

CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation;tryserver.chromium.linux
BUG=565760,423975,520519
==========

to

==========
Enable do not allow default action for untrusted events.

Approved intent to ship:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/WEMnlVIbe70/i2MJcEtN...

BUG=565760,423975,520519
==========

[dtapuska, 2016-06-22 22:11:11]

The CQ bit was checked by dtapuska@chromium.org

[commit-bot: I haz the power, 2016-06-22 22:11:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2070053004/120001

[commit-bot: I haz the power, 2016-06-22 23:40:35]

Description was changed from

==========
Enable do not allow default action for untrusted events.

Approved intent to ship:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/WEMnlVIbe70/i2MJcEtN...

BUG=565760,423975,520519
==========

to

==========
Enable do not allow default action for untrusted events.

Approved intent to ship:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/WEMnlVIbe70/i2MJcEtN...

BUG=565760,423975,520519
==========

[commit-bot: I haz the power, 2016-06-22 23:40:37]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2016-06-22 23:43:33]

Description was changed from

==========
Enable do not allow default action for untrusted events.

Approved intent to ship:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/WEMnlVIbe70/i2MJcEtN...

BUG=565760,423975,520519
==========

to

==========
Enable do not allow default action for untrusted events.

Approved intent to ship:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/WEMnlVIbe70/i2MJcEtN...

BUG=565760,423975,520519

Committed: https://crrev.com/887e8fba784c801afbda06799a99284421408ff1
Cr-Commit-Position: refs/heads/master@{#401463}
==========

[commit-bot: I haz the power, 2016-06-22 23:43:34]

Patchset 7 (id:??) landed as
https://crrev.com/887e8fba784c801afbda06799a99284421408ff1
Cr-Commit-Position: refs/heads/master@{#401463}