Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issue 2070053003: Remove logging added for debugging the lockscreen crashes. (Closed)

Created:
4 years, 6 months ago by jdufault
Modified:
4 years, 6 months ago
Reviewers:
xiyuan, oshima, Daniel Erat
CC:
chromium-reviews, sadrul, derat+watch_chromium.org, dzhioev+watch_chromium.org, achuith+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, kalyank, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@lkgr
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove logging added for debugging the lockscreen crashes. BUG=452599 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/23371b0a9c7cd223174f4e4580823ead12036f03 Cr-Commit-Position: refs/heads/master@{#400817}

Patch Set 1 : #

Total comments: 2

Patch Set 2 : Remove unneeded information #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -130 lines) Patch
M ash/test/test_lock_state_controller_delegate.h View 1 chunk +0 lines, -1 line 0 comments Download
M ash/test/test_lock_state_controller_delegate.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M ash/wm/lock_state_controller.h View 2 chunks +0 lines, -8 lines 0 comments Download
M ash/wm/lock_state_controller.cc View 1 7 chunks +2 lines, -25 lines 0 comments Download
M chrome/browser/chromeos/login/lock/webui_screen_locker.h View 1 chunk +0 lines, -8 lines 0 comments Download
M chrome/browser/chromeos/login/lock/webui_screen_locker.cc View 1 chunk +0 lines, -21 lines 0 comments Download
M chrome/browser/chromeos/login/ui/webui_login_view.h View 1 chunk +0 lines, -11 lines 0 comments Download
M chrome/browser/chromeos/login/ui/webui_login_view.cc View 1 chunk +0 lines, -26 lines 0 comments Download
M chrome/browser/chromeos/power/power_button_observer.cc View 3 chunks +0 lines, -9 lines 0 comments Download
M chrome/browser/chromeos/power/session_state_controller_delegate_chromeos.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/power/session_state_controller_delegate_chromeos.cc View 2 chunks +0 lines, -10 lines 0 comments Download
M chrome/browser/resources/chromeos/login/lock.js View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
jdufault
Oshima, PTAL at ash/ Xiyuan, PTAL at chrome/browser/. This CL just removes some logging used ...
4 years, 6 months ago (2016-06-16 18:05:28 UTC) #5
Daniel Erat
https://codereview.chromium.org/2070053003/diff/20001/ash/wm/lock_state_controller.cc File ash/wm/lock_state_controller.cc (right): https://codereview.chromium.org/2070053003/diff/20001/ash/wm/lock_state_controller.cc#newcode280 ash/wm/lock_state_controller.cc:280: << "(lock_fail_timer_.IsRunning: " << lock_fail_timer_.IsRunning() i don't understand the ...
4 years, 6 months ago (2016-06-16 19:54:09 UTC) #7
jdufault
https://codereview.chromium.org/2070053003/diff/20001/ash/wm/lock_state_controller.cc File ash/wm/lock_state_controller.cc (right): https://codereview.chromium.org/2070053003/diff/20001/ash/wm/lock_state_controller.cc#newcode280 ash/wm/lock_state_controller.cc:280: << "(lock_fail_timer_.IsRunning: " << lock_fail_timer_.IsRunning() On 2016/06/16 19:54:08, Daniel ...
4 years, 6 months ago (2016-06-20 16:36:01 UTC) #8
Daniel Erat
lgtm
4 years, 6 months ago (2016-06-20 16:39:10 UTC) #9
xiyuan
lgtm
4 years, 6 months ago (2016-06-20 16:41:07 UTC) #10
oshima
lgtm
4 years, 6 months ago (2016-06-20 21:36:46 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2070053003/40001
4 years, 6 months ago (2016-06-20 21:45:12 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 6 months ago (2016-06-20 22:50:56 UTC) #15
commit-bot: I haz the power
4 years, 6 months ago (2016-06-20 22:55:40 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/23371b0a9c7cd223174f4e4580823ead12036f03
Cr-Commit-Position: refs/heads/master@{#400817}

Powered by Google App Engine
This is Rietveld 408576698