Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(601)

Issue 2069973003: Links ownership of chrome/test/base/*tracing* to base/trace_events. (Closed)

Created:
4 years, 6 months ago by Lei Zhang
Modified:
4 years, 6 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Links ownership of chrome/test/base/*tracing* to base/trace_events. NOTRY=true Committed: https://crrev.com/62a205ccdc02765ed4120cd81567356961ea7c7c Cr-Commit-Position: refs/heads/master@{#400176}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M chrome/test/base/OWNERS View 1 chunk +2 lines, -0 lines 1 comment Download

Messages

Total messages: 13 (5 generated)
Lei Zhang
I'll take a review from anyone. Please holler if there are any concerns. I will ...
4 years, 6 months ago (2016-06-15 19:43:45 UTC) #2
Primiano Tucci (use gerrit)
LGTM https://codereview.chromium.org/2069973003/diff/1/chrome/test/base/OWNERS File chrome/test/base/OWNERS (right): https://codereview.chromium.org/2069973003/diff/1/chrome/test/base/OWNERS#newcode3 chrome/test/base/OWNERS:3: per-file *tracing*=file://base/trace_event/OWNERS Oh I didn't know you could ...
4 years, 6 months ago (2016-06-16 09:23:40 UTC) #3
dsinclair
lgtm
4 years, 6 months ago (2016-06-16 14:28:30 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2069973003/1
4 years, 6 months ago (2016-06-16 14:28:40 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2069973003/1
4 years, 6 months ago (2016-06-16 16:47:52 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-16 16:53:32 UTC) #10
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-16 16:53:39 UTC) #11
commit-bot: I haz the power
4 years, 6 months ago (2016-06-16 16:55:30 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/62a205ccdc02765ed4120cd81567356961ea7c7c
Cr-Commit-Position: refs/heads/master@{#400176}

Powered by Google App Engine
This is Rietveld 408576698