Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 2069973002: [turbofan] Replace shr of masked bits with zero (Closed)

Created:
4 years, 6 months ago by martyn.capewell
Modified:
4 years, 6 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Replace shr of masked bits with zero If (mask >>> s) == 0, ((x & mask) >> s) == 0, so replace the node with zero in MachineOperatorReducer. BUG= Committed: https://crrev.com/d3597aee1f4caf1110ec1eb0047a2c421faacf12 Cr-Commit-Position: refs/heads/master@{#37046}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -9 lines) Patch
M src/compiler/machine-operator-reducer.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/machine-operator-reducer.cc View 2 chunks +21 lines, -8 lines 0 comments Download
M test/unittests/compiler/machine-operator-reducer-unittest.cc View 1 chunk +17 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
martyn.capewell
4 years, 6 months ago (2016-06-15 10:00:35 UTC) #2
Benedikt Meurer
lgtm
4 years, 6 months ago (2016-06-17 04:21:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2069973002/1
4 years, 6 months ago (2016-06-17 04:21:53 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-17 04:48:41 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-17 04:49:43 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d3597aee1f4caf1110ec1eb0047a2c421faacf12
Cr-Commit-Position: refs/heads/master@{#37046}

Powered by Google App Engine
This is Rietveld 408576698