Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(370)

Issue 2069943003: Mojom target for generating & building C bindings. (Closed)

Created:
4 years, 6 months ago by vardhan
Modified:
4 years, 6 months ago
Reviewers:
azani
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, yzshen+mojopublicwatch_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Mojom target for generating & building C bindings. Note that this target isn't being used, and should not be used until the C bindings library (required by this new mojom target). Adding this target will allow me to start writing unittests progessively against generated C bindings. Changes: - Add a '$TARGET_c' source set target to the mojom template that generates and builds C bindings for the mojom. - Remove redundant '-no-generate-type-info' flag. - Add it to the common generator library. R=azani@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/3839c010ff5b9e8b107c95144251277280548141

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -14 lines) Patch
M mojo/public/tools/bindings/mojom.gni View 5 chunks +47 lines, -9 lines 0 comments Download
A mojo/public/tools/bindings/mojom_tool/bin/linux64/generators/c.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A mojo/public/tools/bindings/mojom_tool/bin/mac64/generators/c.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/public/tools/bindings/run_code_generators.py View 1 chunk +0 lines, -3 lines 0 comments Download
M mojom/generators/c/c_generator.go View 1 chunk +2 lines, -2 lines 0 comments Download
M mojom/generators/common/cli.go View 3 chunks +8 lines, -0 lines 0 comments Download
M mojom/generators/common/common.go View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
vardhan
ptal
4 years, 6 months ago (2016-06-15 06:07:21 UTC) #2
azani
lgtm
4 years, 6 months ago (2016-06-15 18:01:00 UTC) #3
vardhan
4 years, 6 months ago (2016-06-15 18:07:16 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
3839c010ff5b9e8b107c95144251277280548141 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698