src/mips/constants-mips.h - Issue 2069933003: Implement byte swapping instructions on MIPS32 and MIPS64.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/mips/constants-mips.h

Issue 2069933003: Implement byte swapping instructions on MIPS32 and MIPS64. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Address code review remarks. Remove testing already covered in test-macro-assembler-mips64.cc Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/mips/constants-mips.h

diff --git a/src/mips/constants-mips.h b/src/mips/constants-mips.h

index f50a84927af4eeab18aa718f4bfa0023faa1a9ee..8301c5e5de29e7724e4a159c7fe2fc47cf544a8b 100644

--- a/src/mips/constants-mips.h

+++ b/src/mips/constants-mips.h

@@ -1186,11 +1186,10 @@ Instruction::Type Instruction::InstructionType(TypeChecks checks) const {

int sa = SaFieldRaw() >> kSaShift;

switch (sa) {

case BITSWAP:

- return kRegisterType;

case WSBH:

case SEB:

case SEH:

- return kUnsupported;

+ return kRegisterType;

}

sa >>= kBp2Bits;

switch (sa) {

« no previous file with comments | « src/mips/assembler-mips.cc ('k') | src/mips/disasm-mips.cc » ('j') | test/cctest/test-macro-assembler-mips.cc » ('J')