Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Issue 2069923006: [Reland] Add a new app API to enable watchdog behavior restarts in kiosk apps (Closed)

Created:
4 years, 6 months ago by afakhry
Modified:
4 years, 6 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, asvitkine+watch_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Reland] Add a new app API to enable watchdog behavior restarts in kiosk apps Original CL: https://codereview.chromium.org/1970613003/ This CL adds chrome.runtime.restartAfterDelay(int seconds, callback) to enable watchdog behavior restarts in kiosk apps. TBR=xiyuan@chromium.org,rdevlin.cronin@chromium.org,benwells@chromium.org,mpearson@chromium.org,pam@chromium.org BUG=604578 TEST=extensions_unittests --gtest_filter=RestartAfterDelayApiTest.* Committed: https://crrev.com/2bd481835dcc7d0af338de28de9b91f136683cbf Cr-Commit-Position: refs/heads/master@{#400166}

Patch Set 1 : Original CL #

Patch Set 2 : Increase allowed floating point error. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+562 lines, -7 lines) Patch
M chrome/browser/prefs/browser_prefs.cc View 2 chunks +2 lines, -0 lines 0 comments Download
A extensions/browser/api/runtime/restart_after_delay_api_unittest.cc View 1 1 chunk +247 lines, -0 lines 0 comments Download
M extensions/browser/api/runtime/runtime_api.h View 8 chunks +80 lines, -4 lines 0 comments Download
M extensions/browser/api/runtime/runtime_api.cc View 6 chunks +207 lines, -2 lines 0 comments Download
M extensions/browser/extension_function_histogram_value.h View 1 chunk +1 line, -0 lines 0 comments Download
M extensions/browser/test_extensions_browser_client.h View 1 chunk +4 lines, -0 lines 0 comments Download
M extensions/browser/test_extensions_browser_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/common/api/runtime.json View 1 chunk +18 lines, -0 lines 0 comments Download
M extensions/extensions_tests.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
afakhry
Relanding after it was reverted due to a flaky test: RestartAfterDelayApiTest.RestartAfterDelayTest: c:\b\build\slave\drm-cr\build\src\extensions\browser\api\runtime\restart_after_delay_api_unittest.cc(230): error: The difference ...
4 years, 6 months ago (2016-06-16 13:36:42 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2069923006/20001
4 years, 6 months ago (2016-06-16 16:11:43 UTC) #3
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-16 16:17:41 UTC) #4
commit-bot: I haz the power
4 years, 6 months ago (2016-06-16 16:20:40 UTC) #6
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2bd481835dcc7d0af338de28de9b91f136683cbf
Cr-Commit-Position: refs/heads/master@{#400166}

Powered by Google App Engine
This is Rietveld 408576698