Short Circuit Evaluation

src/IceInst.cpp

 //===- subzero/src/IceInst.cpp - High-level instruction implementation ----===//
 //
 //                        The Subzero Code Generator
 //
 // This file is distributed under the University of Illinois Open Source
 // License. See LICENSE.TXT for details.
 //
 //===----------------------------------------------------------------------===//
 ///
 /// \file
@@ skipping 59 matching lines @@
   { str }                                                                      \
   ,
     ICEINSTICMP_TABLE
 #undef X
 };
 
 } // end of anonymous namespace
 
 Inst::Inst(Cfg *Func, InstKind Kind, SizeT MaxSrcs, Variable *Dest)
     : Kind(Kind), Number(Func->newInstNumber()), Dest(Dest), MaxSrcs(MaxSrcs),
-      Srcs(Func->allocateArrayOf<Operand *>(MaxSrcs)), LiveRangesEnded(0) {}
+      LiveRangesEnded(0) {
+  Srcs.reserve(MaxSrcs);
+}
 
 const char *Inst::getInstName() const {
   if (!BuildDefs::dump())
     return "???";
 
   switch (Kind) {
 #define X(InstrKind, name)                                                     \
   case InstrKind:                                                              \
     return name
     X(Unreachable, "unreachable");
@@ skipping 295 matching lines @@
   addSource(Source3);
 }
 
 InstLoad::InstLoad(Cfg *Func, Variable *Dest, Operand *SourceAddr)
     : InstHighLevel(Func, Inst::Load, 1, Dest) {
   addSource(SourceAddr);
 }
 
 InstPhi::InstPhi(Cfg *Func, SizeT MaxSrcs, Variable *Dest)
     : InstHighLevel(Func, Phi, MaxSrcs, Dest) {
-  Labels = Func->allocateArrayOf<CfgNode *>(MaxSrcs);
+  Labels.reserve(MaxSrcs);
 }
 
 // TODO: A Switch instruction (and maybe others) can add duplicate edges. We
 // may want to de-dup Phis and validate consistency (i.e., the source operands
 // are the same for duplicate edges), though it seems the current lowering code
 // is OK with this situation.
 void InstPhi::addArgument(Operand *Source, CfgNode *Label) {
-  Labels[getSrcSize()] = Label;
+  assert(Label);
+  Labels.push_back(Label);
   addSource(Source);
 }
 
 // Find the source operand corresponding to the incoming edge for the given
 // node.
 Operand *InstPhi::getOperandForTarget(CfgNode *Target) const {
   for (SizeT I = 0; I < getSrcSize(); ++I) {
     if (Labels[I] == Target)
       return getSrc(I);
   }
@@ skipping 676 matching lines @@
     // upper 32 bits of rax. We need to recognize and preserve these.
     return true;
   }
   if (!Dest->hasReg() && !SrcVar->hasReg() &&
       Dest->getStackOffset() == SrcVar->getStackOffset())
     return true;
   return false;
 }
 
 } // end of namespace Ice