appengine/swarming/swarming_rpcs.py - Issue 2069903003: swarming: custom cipd package paths

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: appengine/swarming/swarming_rpcs.py

Issue 2069903003: swarming: custom cipd package paths (Closed) Base URL: https://chromium.googlesource.com/external/github.com/luci/luci-py@cipd-win

Patch Set: test "." and None custom path Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« appengine/swarming/swarming_bot/bot_code/task_runner.py ('K') | « appengine/swarming/swarming_bot/bot_code/task_runner_test.py ('k') | appengine/swarming/templates/user_task.html » ('j') | client/isolateserver.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: appengine/swarming/swarming_rpcs.py

diff --git a/appengine/swarming/swarming_rpcs.py b/appengine/swarming/swarming_rpcs.py

index f8b454933794452ebe8fe8b2cb3d284716fd31e6..98c0a3bc738e3ccb5ddc9dd8c0562bc730a1984d 100644

--- a/appengine/swarming/swarming_rpcs.py

+++ b/appengine/swarming/swarming_rpcs.py

@@ -90,6 +90,9 @@ class CipdPackage(messages.Message):

package_name = messages.StringField(1)

# Valid package version for all packages matched by package name.

version = messages.StringField(2)

+ # Path to dir, relative to the run dir, where to install the package.

M-A Ruel 2016/06/15 17:28:27 root dir? because this can be confused with relati

nodir 2016/06/15 17:53:42 Done.

+ # If empty, the package will be installed in run dir.

M-A Ruel 2016/06/15 17:28:27 in run dir? will be installed a the root of the ma

nodir 2016/06/15 17:53:42 Done.

+ path = messages.StringField(3)

class CipdInput(messages.Message):

@@ -106,6 +109,7 @@ class CipdInput(messages.Message):

# CIPD package of CIPD client to use.

# client_package.version is required.

# This field is optional is default value is defined in the server config.

+ # client_package.path is ignored.

M-A Ruel 2016/06/15 17:28:27 must be empty

nodir 2016/06/15 17:53:42 Done.

client_package = messages.MessageField(CipdPackage, 2)

# List of CIPD packages to install in $CIPD_PATH prior task execution.