Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1683)

Unified Diff: appengine/swarming/server/task_request_test.py

Issue 2069903003: swarming: custom cipd package paths (Closed) Base URL: https://chromium.googlesource.com/external/github.com/luci/luci-py@cipd-win
Patch Set: fix _validate_cipd_path Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « appengine/swarming/server/task_request.py ('k') | appengine/swarming/swarming_bot/bot_code/task_runner.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: appengine/swarming/server/task_request_test.py
diff --git a/appengine/swarming/server/task_request_test.py b/appengine/swarming/server/task_request_test.py
index 563e3b69fe1853300277de1fe6fd8d7fc1440b97..884c523cdb7ac8716eefe0298bff9470557f84f8 100755
--- a/appengine/swarming/server/task_request_test.py
+++ b/appengine/swarming/server/task_request_test.py
@@ -49,6 +49,7 @@ def _gen_request(properties=None, **kwargs):
}),
'packages': [{
'package_name': 'rm',
+ 'path': 'bin',
'version': 'git_revision:deadbeef',
}],
'server': 'https://chrome-infra-packages.appspot.com'
@@ -217,10 +218,12 @@ class TaskRequestApiTest(TestCase):
'cipd_input': {
'client_package': {
'package_name': 'infra/tools/cipd/${platform}',
+ 'path': None,
'version': 'git_revision:deadbeef',
},
'packages': [{
'package_name': 'rm',
+ 'path': 'bin',
'version': 'git_revision:deadbeef',
}],
'server': 'https://chrome-infra-packages.appspot.com'
@@ -251,7 +254,7 @@ class TaskRequestApiTest(TestCase):
'properties': expected_properties,
# Intentionally hard code the hash value since it has to be deterministic.
# Other unit tests should use the calculated value.
- 'properties_hash': 'c07adb3b577d51169036f29e44764a5ddf132228',
+ 'properties_hash': '411f20b8cda819b5fe47bcf26f5566c37afce0ed',
'pubsub_topic': None,
'pubsub_userdata': None,
'tags': [
@@ -287,10 +290,12 @@ class TaskRequestApiTest(TestCase):
'cipd_input': {
'client_package': {
'package_name': 'infra/tools/cipd/${platform}',
+ 'path': None,
'version': 'git_revision:deadbeef',
},
'packages': [{
'package_name': 'rm',
+ 'path': 'bin',
'version': 'git_revision:deadbeef',
}],
'server': 'https://chrome-infra-packages.appspot.com'
@@ -321,7 +326,7 @@ class TaskRequestApiTest(TestCase):
'properties': expected_properties,
# Intentionally hard code the hash value since it has to be deterministic.
# Other unit tests should use the calculated value.
- 'properties_hash': 'c07adb3b577d51169036f29e44764a5ddf132228',
+ 'properties_hash': '411f20b8cda819b5fe47bcf26f5566c37afce0ed',
'pubsub_topic': None,
'pubsub_userdata': None,
'tags': [
@@ -361,7 +366,7 @@ class TaskRequestApiTest(TestCase):
# Other unit tests should use the calculated value.
# Ensure the algorithm is deterministic.
self.assertEqual(
- 'c07adb3b577d51169036f29e44764a5ddf132228', as_dict['properties_hash'])
+ '411f20b8cda819b5fe47bcf26f5566c37afce0ed', as_dict['properties_hash'])
def test_duped(self):
# Two TestRequest with the same properties.
@@ -529,10 +534,12 @@ class TaskRequestApiTest(TestCase):
'cipd_input': {
'client_package': {
'package_name': 'infra/tools/cipd/${platform}',
+ 'path': None,
'version': 'git_revision:deadbeef',
},
'packages': [{
'package_name': 'rm',
+ 'path': 'bin',
'version': 'git_revision:deadbeef',
}],
'server': 'https://chrome-infra-packages.appspot.com'
« no previous file with comments | « appengine/swarming/server/task_request.py ('k') | appengine/swarming/swarming_bot/bot_code/task_runner.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698