swarming: custom cipd package paths

client/tests/run_isolated_test.py

 #!/usr/bin/env python
 # Copyright 2013 The LUCI Authors. All rights reserved.
 # Use of this source code is governed under the Apache License, Version 2.0
 # that can be found in the LICENSE file.
 
 # pylint: disable=R0201
 
 import StringIO
 import base64
 import functools
@@ skipping 190 matching lines @@
         isolated_hash,
         StorageFake(files),
         isolateserver.MemoryCache(),
         False,
         None,
         None,
         None,
         None,
         None,
         None,
-        None,
-        None)
+        lambda run_dir: None)
     self.assertEqual(0, ret)
     return make_tree_call
 
   def test_run_tha_test_naked(self):
     isolated = json_dumps({'command': ['invalid', 'command']})
     isolated_hash = isolateserver_mock.hash_content(isolated)
     files = {isolated_hash:isolated}
     make_tree_call = self._run_tha_test(isolated_hash, files)
     self.assertEqual(
         [
@@ skipping 105 matching lines @@
       'world',
     ]
     ret = run_isolated.main(cmd)
     self.assertEqual(1, ret)
     self.assertEqual(1, len(self.popen_calls))
     self.assertEqual(
         [([u'/bin/echo', u'hello', u'world'], {'detached': True})],
         self.popen_calls)
 
   def test_main_naked_with_packages(self):
-    cmd = [
-      '--no-log',
-      '--cipd-package', 'infra/tools/echo/${platform}:latest',
-      '--cipd-server', self.cipd_server.url,
-      '${CIPD_PATH}/echo',
-      'hello',
-      'world',
-    ]
-    ret = run_isolated.main(cmd)
-    self.assertEqual(0, ret)
+    packages_fd, packages_path = tempfile.mkstemp(prefix=u'packages')
+    try:
+      try:
+        os.write(packages_fd, json.dumps({
+          'packages': [
+            {
+              'path': 'bin',
+              'package_name': 'infra/tools/echo/${platform}',
+              'version': 'latest',
+            },
+            {
+              'path': '.',
+              'package_name': 'infra/data/x',
+              'version': 'latest',
+            },
+            {
+              'package_name': 'infra/data/y',
+              'version': 'canary',
+            },
+          ]
+        }))
+      finally:
+        os.close(packages_fd)
 
-    self.assertEqual(2, len(self.popen_calls))
+      cmd = [
+        '--no-log',
+        '--cipd-package-list', packages_path,
+        '--cipd-server', self.cipd_server.url,
+        'bin/echo${EXECUTABLE_SUFFIX}',
+        'hello',
+        'world',
+      ]
+      ret = run_isolated.main(cmd)
+      self.assertEqual(0, ret)
 
-    # Test cipd-ensure command.
-    cipd_ensure_cmd, _ = self.popen_calls[0]
-    self.assertEqual(cipd_ensure_cmd[:2], [
-      os.path.abspath('cipd_cache/cipd' + cipd.EXECUTABLE_SUFFIX),
-      'ensure',
-    ])
-    cache_dir_index = cipd_ensure_cmd.index('-cache-dir')
-    self.assertEqual(
-        cipd_ensure_cmd[cache_dir_index+1],
-        os.path.abspath('cipd_cache/cipd_internal'))
+      print self.popen_calls
+      self.assertEqual(3, len(self.popen_calls))
 
-    # Test cipd cache.
-    version_file = unicode(os.path.abspath(
-        'cipd_cache/versions/1481d0a0ceb16ea4672fed76a0710306eb9f3a33'))
-    self.assertTrue(fs.isfile(version_file))
-    with open(version_file) as f:
-      self.assertEqual(f.read(), 'aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa')
+      # Test cipd-ensure command for installing packages.
+      for cipd_ensure_cmd, _ in self.popen_calls[0:2]:
+        self.assertEqual(cipd_ensure_cmd[:2], [
+          os.path.abspath('cipd_cache/cipd' + cipd.EXECUTABLE_SUFFIX),
+          'ensure',
+        ])
+        cache_dir_index = cipd_ensure_cmd.index('-cache-dir')
+        self.assertEqual(
+            cipd_ensure_cmd[cache_dir_index+1],
+            os.path.abspath('cipd_cache/cipd_internal'))
 
-    client_binary_file = unicode(os.path.abspath(
-        'cipd_cache/clients/aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa'))
-    self.assertTrue(fs.isfile(client_binary_file))
+      # Test cipd cache.
+      version_file = unicode(os.path.abspath(
+          'cipd_cache/versions/1481d0a0ceb16ea4672fed76a0710306eb9f3a33'))
+      self.assertTrue(fs.isfile(version_file))
+      with open(version_file) as f:
+        self.assertEqual(f.read(), 'aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa')
 
-    # Test echo call.
-    echo_cmd, _ = self.popen_calls[1]
-    self.assertTrue(echo_cmd[0].endswith('cipd_site_root/echo'))
-    self.assertEqual(echo_cmd[1:], ['hello', 'world'])
+      client_binary_file = unicode(os.path.abspath(
+          'cipd_cache/clients/aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa'))
+      self.assertTrue(fs.isfile(client_binary_file))
+
+      # Test echo call.
+      echo_cmd, _ = self.popen_calls[2]
+      self.assertTrue(echo_cmd[0].endswith(
+          '/bin/echo' + cipd.EXECUTABLE_SUFFIX))
+      self.assertEqual(echo_cmd[1:], ['hello', 'world'])
+    finally:
+      os.remove(packages_path)
 
   def test_modified_cwd(self):
     isolated = json_dumps({
         'command': ['../out/some.exe', 'arg'],
         'relative_cwd': 'some',
     })
     isolated_hash = isolateserver_mock.hash_content(isolated)
     files = {isolated_hash:isolated}
     _ = self._run_tha_test(isolated_hash, files)
     self.assertEqual(1, len(self.popen_calls))
@@ skipping 60 matching lines @@
           None,
           isolated_hash,
           store,
           isolateserver.MemoryCache(),
           False,
           None,
           None,
           None,
           None,
           None,
-          [],
           None,
-          None)
+          lambda run_dir: None)
       self.assertEqual(0, ret)
 
       # It uploaded back. Assert the store has a new item containing foo.
       hashes = {isolated_hash, script_hash}
       output_hash = isolateserver_mock.hash_content('bar')
       hashes.add(output_hash)
       isolated =  {
         'algo': 'sha-1',
         'files': {
           'foo': {
@@ skipping 133 matching lines @@
     self.assertEqual(expected, actual)
 
 
 if __name__ == '__main__':
   fix_encoding.fix_encoding()
   if '-v' in sys.argv:
     unittest.TestCase.maxDiff = None
   logging.basicConfig(
       level=logging.DEBUG if '-v' in sys.argv else logging.ERROR)
   unittest.main()