Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1521)

Unified Diff: test/browser/language_tests.js

Issue 2069903002: Partial fix for call methods #542 (Closed) Base URL: git@github.com:dart-lang/dev_compiler.git@master
Patch Set: fix to not use dcall Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/src/compiler/code_generator.dart ('k') | tool/input_sdk/private/ddc_runtime/classes.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/browser/language_tests.js
diff --git a/test/browser/language_tests.js b/test/browser/language_tests.js
index 6f51b94de54a359f1621f74d7f1addf389b7327c..0ba409bf4db872cde6103406595bb0cd75c7f484 100644
--- a/test/browser/language_tests.js
+++ b/test/browser/language_tests.js
@@ -60,14 +60,11 @@
'bool_test': skip_fail,
'bound_closure_equality_test': skip_fail,
'branch_canonicalization_test': skip_fail, // JS bit operations truncate to 32 bits.
- 'call_closurization_test': skip_fail,
- 'call_function_apply_test': skip_fail,
- 'call_operator_test': skip_fail,
- 'call_property_test': skip_fail,
- 'call_test': skip_fail,
- 'call_this_test': skip_fail,
- 'call_through_null_getter_test': skip_fail,
- 'call_with_no_such_method_test': skip_fail,
+ 'call_closurization_test': fail, // Functions do not expose a "call" method.
+ 'call_function_apply_test': fail, // Function.apply not really implemented.
+ 'call_test': fail, // Functions do not expose a "call" method.
+ 'call_through_null_getter_test': fail, // null errors are not converted to NoSuchMethodErrors.
+ 'call_with_no_such_method_test': fail, // Function.apply not really implemented.
'canonical_const2_test': skip_fail,
'canonical_const_test': skip_fail,
'cascade_precedence_test': skip_fail,
@@ -164,13 +161,13 @@
'function_subtype_bound_closure5_test': skip_fail,
'function_subtype_bound_closure5a_test': skip_fail,
'function_subtype_bound_closure6_test': skip_fail,
- 'function_subtype_call0_test': skip_fail,
- 'function_subtype_call1_test': skip_fail,
- 'function_subtype_call2_test': skip_fail,
- 'function_subtype_cast0_test': skip_fail,
- 'function_subtype_cast1_test': skip_fail,
- 'function_subtype_cast2_test': skip_fail,
- 'function_subtype_cast3_test': skip_fail,
+ 'function_subtype_call0_test': fail, // Strong mode "is" rejects some type tests.
+ 'function_subtype_call1_test': fail,
+ 'function_subtype_call2_test': fail,
+ 'function_subtype_cast0_test': fail,
+ 'function_subtype_cast1_test': fail,
+ 'function_subtype_cast2_test': fail,
+ 'function_subtype_cast3_test': fail,
'function_subtype_factory0_test': skip_fail,
'function_subtype_inline0_test': skip_fail,
'function_subtype_local0_test': skip_fail,
@@ -197,7 +194,6 @@
'function_type_alias4_test': skip_fail,
'function_type_alias6_test_none_multi': skip_fail,
'function_type_alias_test': skip_fail,
- 'function_type_call_getter_test': skip_fail,
'gc_test': skip_fail,
'generic_field_mixin2_test': skip_fail,
'generic_field_mixin3_test': skip_fail,
« no previous file with comments | « lib/src/compiler/code_generator.dart ('k') | tool/input_sdk/private/ddc_runtime/classes.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698