Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Unified Diff: services/media/factory_service/media_player_impl.h

Issue 2069873003: Motown: Define MediaRenderer and make it the way we identify renderers. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Fix build break...audio_track_controller.* gone for good. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: services/media/factory_service/media_player_impl.h
diff --git a/services/media/factory_service/media_player_impl.h b/services/media/factory_service/media_player_impl.h
index 195b76e9aafbf6e9b1cfa809cadb4aaa52237634..1f915e8839a63c50fb912e586c22c7b41db9e6eb 100644
--- a/services/media/factory_service/media_player_impl.h
+++ b/services/media/factory_service/media_player_impl.h
@@ -28,6 +28,8 @@ class MediaPlayerImpl : public MediaFactoryService::Product<MediaPlayer>,
public:
static std::shared_ptr<MediaPlayerImpl> Create(
InterfaceHandle<SeekingReader> reader,
+ InterfaceHandle<MediaRenderer> audio_renderer,
+ InterfaceHandle<MediaRenderer> video_renderer,
InterfaceRequest<MediaPlayer> request,
MediaFactoryService* owner);
@@ -63,9 +65,12 @@ class MediaPlayerImpl : public MediaFactoryService::Product<MediaPlayer>,
// problems.
MediaProducerPtr encoded_producer_;
MediaProducerPtr decoded_producer_;
+ InterfaceHandle<MediaRenderer> renderer_;
};
MediaPlayerImpl(InterfaceHandle<SeekingReader> reader,
+ InterfaceHandle<MediaRenderer> audio_renderer,
+ InterfaceHandle<MediaRenderer> video_renderer,
InterfaceRequest<MediaPlayer> request,
MediaFactoryService* owner);
@@ -87,13 +92,11 @@ class MediaPlayerImpl : public MediaFactoryService::Product<MediaPlayer>,
void PrepareStream(Stream* stream,
size_t index,
const MediaTypePtr& input_media_type,
- const String& url,
const std::function<void()>& callback);
// Creates a sink for a stream.
void CreateSink(Stream* stream,
const MediaTypePtr& input_media_type,
- const String& url,
const std::function<void()>& callback);
// Handles a metadata update from the demux. When called with the default
@@ -124,6 +127,10 @@ class MediaPlayerImpl : public MediaFactoryService::Product<MediaPlayer>,
CallbackJoiner set_transform_joiner_;
MediaMetadataPtr metadata_;
MojoPublisher<GetStatusCallback> status_publisher_;
+ // The following fields are just temporaries used to solve lambda capture
+ // problems.
+ InterfaceHandle<MediaRenderer> audio_renderer_;
+ InterfaceHandle<MediaRenderer> video_renderer_;
};
} // namespace media
« no previous file with comments | « services/media/factory_service/factory_service.cc ('k') | services/media/factory_service/media_player_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698