Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1624)

Unified Diff: mojo/services/media/control/interfaces/media_factory.mojom

Issue 2069873003: Motown: Define MediaRenderer and make it the way we identify renderers. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Fix build break...audio_track_controller.* gone for good. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/services/media/control/interfaces/media_factory.mojom
diff --git a/mojo/services/media/control/interfaces/media_factory.mojom b/mojo/services/media/control/interfaces/media_factory.mojom
index 6ad372abb6c71a87d481cfc9321073c51c960dd8..dcad5997996c578daa53048f282ba676156cfc39 100644
--- a/mojo/services/media/control/interfaces/media_factory.mojom
+++ b/mojo/services/media/control/interfaces/media_factory.mojom
@@ -10,6 +10,7 @@ import "mojo/services/media/control/interfaces/media_player.mojom";
import "mojo/services/media/control/interfaces/media_sink.mojom";
import "mojo/services/media/control/interfaces/media_source.mojom";
import "mojo/services/media/core/interfaces/media_demux.mojom";
+import "mojo/services/media/core/interfaces/media_renderer.mojom";
import "mojo/services/media/core/interfaces/media_type_converter.mojom";
import "mojo/services/media/core/interfaces/seeking_reader.mojom";
import "mojo/services/media/core/interfaces/timeline_controller.mojom";
@@ -18,8 +19,10 @@ import "mojo/services/media/core/interfaces/timeline_controller.mojom";
[ServiceName="mojo::media::MediaFactory"]
interface MediaFactory {
// Creates a player.
- // TODO(dalesat): Add means of specifying destinations.
- CreatePlayer(SeekingReader reader, MediaPlayer& player);
+ CreatePlayer(SeekingReader reader,
+ MediaRenderer? audio_renderer,
+ MediaRenderer? video_renderer,
+ MediaPlayer& player);
// Creates a source. If allowed_media_types is supplied, conversions will be
// added to each stream as needed to make the media type of the stream match
@@ -31,9 +34,10 @@ interface MediaFactory {
MediaSource& source);
// Creates a sink. Conversions are added to the pipeline as appropriate to
- // convert the indicated media type to a type compatible with the
- // destination.
- CreateSink(string destination_url, MediaType media_type, MediaSink& sink);
+ // convert a media type supported by the renderer.
+ CreateSink(MediaRenderer? renderer,
+ MediaType media_type,
+ MediaSink& sink);
// Creates a demux.
CreateDemux(SeekingReader reader, MediaDemux& demux);
« no previous file with comments | « mojo/services/media/audio/interfaces/audio_track.mojom ('k') | mojo/services/media/core/interfaces/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698