content/browser/ppapi_plugin_process_host.cc - Issue 2069853002: Ignore certain messages in plugin broker process if they are not sent by the

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/ppapi_plugin_process_host.cc

Issue 2069853002: Ignore certain messages in plugin broker process if they are not sent by the (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/ppapi_plugin_process_host.h ('k') | content/ppapi_plugin/broker_process_dispatcher.h » ('j') | content/ppapi_plugin/broker_process_dispatcher.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/ppapi_plugin_process_host.cc

diff --git a/content/browser/ppapi_plugin_process_host.cc b/content/browser/ppapi_plugin_process_host.cc

index 478f476f36d1370785b56029fe2e4173c588db02..6e306934c07b8f31cd0f4014e186bbef33ad6056 100644

--- a/content/browser/ppapi_plugin_process_host.cc

+++ b/content/browser/ppapi_plugin_process_host.cc

@@ -467,8 +467,12 @@ void PpapiPluginProcessHost::RequestPluginChannel(Client* client) {

int renderer_child_id;

client->GetPpapiChannelInfo(&process_handle, &renderer_child_id);

- base::ProcessId process_id = (process_handle == base::kNullProcessHandle) ?

- 0 : base::GetProcId(process_handle);

+ base::ProcessId process_id = base::kNullProcessId;

+ if (process_handle != base::kNullProcessHandle) {

+ // This channel is not used by the browser itself.

+ process_id = base::GetProcId(process_handle);

+ CHECK_NE(base::kNullProcessId, process_id);

+ }

// We can't send any sync messages from the browser because it might lead to

// a hang. See the similar code in PluginProcessHost for more description.