Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(320)

Issue 2069823004: Fix InputDevice StructTraits. (Closed)

Created:
4 years, 6 months ago by kylechar
Modified:
4 years, 6 months ago
Reviewers:
kenrb, sadrul
CC:
chromium-reviews, qsr+mojo_chromium.org, tdresser+watch_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@mojo_device
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix InputDevice StructTraits. The StructTraits for InputDevice won't compile due to strict warnings on Chrome OS and not producing an object file on Windows. Fix both of those problems. Also use this change to move the enum switch statements into an EnumTraits and combine the two typemap files into one. BUG=601981 Committed: https://crrev.com/6f6a2cb61603a8006b6c6b76ff342ede47acd85b Cr-Commit-Position: refs/heads/master@{#400428}

Patch Set 1 #

Patch Set 2 : Formatting. #

Total comments: 2

Patch Set 3 : Run gn format. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+112 lines, -76 lines) Patch
M ui/events/devices/mojo/input_device.typemap View 1 2 1 chunk +17 lines, -5 lines 0 comments Download
M ui/events/devices/mojo/input_device_struct_traits.h View 3 chunks +11 lines, -51 lines 0 comments Download
A ui/events/devices/mojo/input_device_struct_traits.cc View 1 chunk +83 lines, -0 lines 0 comments Download
D ui/events/devices/mojo/touchscreen_device.typemap View 1 chunk +0 lines, -16 lines 0 comments Download
M ui/events/devices/mojo/typemaps.gni View 1 chunk +1 line, -4 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 15 (6 generated)
kylechar
+kenrb for input_device_struct_traits.cc/h, +sadrul for other files.
4 years, 6 months ago (2016-06-16 13:11:30 UTC) #2
sadrul
lgtm https://codereview.chromium.org/2069823004/diff/20001/ui/events/devices/mojo/input_device.typemap File ui/events/devices/mojo/input_device.typemap (right): https://codereview.chromium.org/2069823004/diff/20001/ui/events/devices/mojo/input_device.typemap#newcode25 ui/events/devices/mojo/input_device.typemap:25: "ui.mojom.InputDevice=ui::InputDevice", sort
4 years, 6 months ago (2016-06-16 16:04:44 UTC) #3
kylechar
Thanks Sadrul! https://codereview.chromium.org/2069823004/diff/20001/ui/events/devices/mojo/input_device.typemap File ui/events/devices/mojo/input_device.typemap (right): https://codereview.chromium.org/2069823004/diff/20001/ui/events/devices/mojo/input_device.typemap#newcode25 ui/events/devices/mojo/input_device.typemap:25: "ui.mojom.InputDevice=ui::InputDevice", On 2016/06/16 16:04:43, sadrul wrote: > ...
4 years, 6 months ago (2016-06-16 17:09:57 UTC) #4
kenrb
lgtm
4 years, 6 months ago (2016-06-17 10:34:45 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2069823004/40001
4 years, 6 months ago (2016-06-17 13:04:48 UTC) #8
commit-bot: I haz the power
Failed to apply the patch.
4 years, 6 months ago (2016-06-17 14:05:02 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2069823004/40001
4 years, 6 months ago (2016-06-17 14:53:53 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 6 months ago (2016-06-17 14:58:54 UTC) #13
commit-bot: I haz the power
4 years, 6 months ago (2016-06-17 15:01:21 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/6f6a2cb61603a8006b6c6b76ff342ede47acd85b
Cr-Commit-Position: refs/heads/master@{#400428}

Powered by Google App Engine
This is Rietveld 408576698