src/isolate.h - Issue 2069823003: [wasm] Enable wasm frame inspection for debugging

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/isolate.h

Issue 2069823003: [wasm] Enable wasm frame inspection for debugging (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@split-wasm-debug

Patch Set: rebase & address more comments Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/isolate.h

diff --git a/src/isolate.h b/src/isolate.h

index 4ca842e5ea64b1dac6b442a4eee2712688f0a493..a5c13286984fd9fa2f48f458767d88136aa13168 100644

--- a/src/isolate.h

+++ b/src/isolate.h

@@ -1464,7 +1464,7 @@ class SaveContext BASE_EMBEDDED {

SaveContext* prev() { return prev_; }

// Returns true if this save context is below a given JavaScript frame.

- bool IsBelowFrame(JavaScriptFrame* frame) {

+ bool IsBelowFrame(StandardFrame* frame) {

return (c_entry_fp_ == 0) || (c_entry_fp_ > frame->sp());

}

« src/debug/debug.cc ('K') | « src/frames-inl.h ('k') | src/isolate.cc » ('j') | src/runtime/runtime-debug.cc » ('J')