Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Unified Diff: src/isolate.cc

Issue 2069823003: [wasm] Enable wasm frame inspection for debugging (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@split-wasm-debug
Patch Set: fix gcmole reports Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« src/debug/mirrors.js ('K') | « src/isolate.h ('k') | src/objects.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/isolate.cc
diff --git a/src/isolate.cc b/src/isolate.cc
index b6c90ba319cd51cd2a3136b728cdd45c504b494a..ec74d7300814aa6cbf0aa315a47975c40d8ffc0d 100644
--- a/src/isolate.cc
+++ b/src/isolate.cc
@@ -39,6 +39,7 @@
#include "src/v8.h"
#include "src/version.h"
#include "src/vm-state-inl.h"
+#include "src/wasm/wasm-debug.h"
#include "src/wasm/wasm-module.h"
namespace v8 {
@@ -627,6 +628,16 @@ class CaptureStackTraceHelper {
isolate_->factory()->NewNumberFromInt(position),
NONE);
}
+ if (!script_id_key_.is_null()) {
+ Object* wasm_obj = frame->wasm_obj();
+ int script_id = wasm_obj->IsUndefined(isolate_)
+ ? -1
+ : wasm::GetDebugInfo(JSObject::cast(wasm_obj))
+ ->GetFunctionScript(frame->function_index())
+ ->id();
+ JSObject::AddProperty(stack_frame, script_id_key_,
+ handle(Smi::FromInt(script_id), isolate_), NONE);
+ }
return stack_frame;
}
« src/debug/mirrors.js ('K') | « src/isolate.h ('k') | src/objects.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698