src/objects.cc - Issue 2069823003: [wasm] Enable wasm frame inspection for debugging

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/objects.cc

Issue 2069823003: [wasm] Enable wasm frame inspection for debugging (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@split-wasm-debug

Patch Set: Add two DCHECKs Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/objects.cc

diff --git a/src/objects.cc b/src/objects.cc

index 15da7353b87cc478130e93bf9b4642cb33dc393a..2e16e0d932c82c92f1dd28717ec0ea70ce312acd 100644

--- a/src/objects.cc

+++ b/src/objects.cc

@@ -12725,7 +12725,8 @@ bool Script::GetPositionInfo(int position, PositionInfo* info,

if (info->line_end > 0) {

DCHECK(script->source()->IsString());

Handle<String> src(String::cast(script->source()));

- if (src->Get(info->line_end - 1) == '\r') {

+ if (src->length() >= info->line_end &&

+ src->Get(info->line_end - 1) == '\r') {

info->line_end--;

}

« no previous file with comments | « src/objects.h ('k') | src/runtime/runtime-debug.cc » ('j') | no next file with comments »