src/isolate.cc - Issue 2069823003: [wasm] Enable wasm frame inspection for debugging

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/isolate.cc

Issue 2069823003: [wasm] Enable wasm frame inspection for debugging (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@split-wasm-debug

Patch Set: Add two DCHECKs Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/isolate.cc

diff --git a/src/isolate.cc b/src/isolate.cc

index c5e2640544d0f352d3eea38b8e004812d6414c7a..edf92eec5cb8e84f7534337a4abfce1c1cb132a7 100644

--- a/src/isolate.cc

+++ b/src/isolate.cc

@@ -628,6 +628,11 @@ class CaptureStackTraceHelper {

isolate_->factory()->NewNumberFromInt(position),

NONE);

}

+ if (!script_id_key_.is_null()) {

+ int script_id = frame->script()->id();

+ JSObject::AddProperty(stack_frame, script_id_key_,

+ handle(Smi::FromInt(script_id), isolate_), NONE);

+ }

return stack_frame;

}

« no previous file with comments | « src/isolate.h ('k') | src/objects.h » ('j') | no next file with comments »