third_party/WebKit/Tools/Scripts/webkitpy/common/net/layouttestresults_unittest.py - Issue 2069743002: Rebaseline the actual missing results only

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/common/net/layouttestresults_unittest.py

Issue 2069743002: Rebaseline the actual missing results only (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/common/net/layouttestresults.py ('k') | third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py » ('j') | third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Tools/Scripts/webkitpy/common/net/layouttestresults_unittest.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/common/net/layouttestresults_unittest.py b/third_party/WebKit/Tools/Scripts/webkitpy/common/net/layouttestresults_unittest.py

index 5fa22fe4773e598ae24b2c594c958b403d73d402..68e7149d86ffc7c8fa3c377bedb5021db483edb1 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/common/net/layouttestresults_unittest.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/common/net/layouttestresults_unittest.py

@@ -105,6 +105,6 @@ class LayoutTestResultsTest(unittest.TestCase):

def test_actual_results(self):

results = LayoutTestResults.results_from_string(self.example_full_results_json)

- self.assertEqual(results.actual_results("fast/dom/prototype-banana.html"), "PASS")

- self.assertEqual(results.actual_results("fast/dom/prototype-taco.html"), "PASS TEXT")

- self.assertEqual(results.actual_results("nonexistant.html"), "")

+ self.assertEqual(results.result_for_test("fast/dom/prototype-banana.html").actual_results(), "PASS")

+ self.assertEqual(results.result_for_test("fast/dom/prototype-taco.html").actual_results(), "PASS TEXT")

+ self.assertFalse(results.result_for_test("nonexistant.html"))