MD - Use real comboboxes in website settings popup. Hide borders (but

ui/views/controls/combobox/combobox.h

Index: ui/views/controls/combobox/combobox.h
diff --git a/ui/views/controls/combobox/combobox.h b/ui/views/controls/combobox/combobox.h
index a3112c7eb9cde23f28b21540bd644672fe5810f3..857799708c09419cc90d619c54a84e277c5d8e52 100644
--- a/ui/views/controls/combobox/combobox.h
+++ b/ui/views/controls/combobox/combobox.h
@@ -105,6 +105,11 @@ class VIEWS_EXPORT Combobox : public PrefixDelegate, public ButtonListener {
   // Overriden from ButtonListener:
   void ButtonPressed(Button* sender, const ui::Event& event) override;
 
+ protected:
+  void set_size_to_largest_label(bool size_to_largest_label) {
+    size_to_largest_label_ = size_to_largest_label;

[sky, 2016/06/16 21:58:55]

Why do you need to change this? It makes sense for STYLE_ACTION because the
selected index effectively never changes. Is that the case with permissions?

[Evan Stade, 2016/06/16 22:04:32]

We're getting rid of the border, and it just looks weird to have the arrow
hanging way off to the right (due to some extra-long label that's not selected
and not currently visible). It looks much better right next to the text, even if
it does move when you select a longer or shorter option.

+  }
+
  private:
   friend class test::ComboboxTestApi;
 
@@ -204,6 +209,10 @@ class VIEWS_EXPORT Combobox : public PrefixDelegate, public ButtonListener {
   // The image to be drawn for this combobox's arrow.
   gfx::ImageSkia arrow_image_;
 
+  // When true, the size of contents is defined by the selected label.
+  // Otherwise, it's defined by the widest label in the menu.
+  bool size_to_largest_label_;
+
   // Used for making calbacks.
   base::WeakPtrFactory<Combobox> weak_ptr_factory_;