Issue 2069713002: Make all gesture scrolls use customization path internally

bokan

The CQ bit was checked by bokan@chromium.org to run a CQ dry run

4 years, 6 months ago (2016-06-14 20:21:12 UTC) #1

commit-bot: I haz the power

Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2069713002/20001

4 years, 6 months ago (2016-06-14 20:21:45 UTC) #2

commit-bot: I haz the power

The CQ bit was unchecked by commit-bot@chromium.org

4 years, 6 months ago (2016-06-14 21:30:55 UTC) #3

commit-bot: I haz the power

Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/246410)

4 years, 6 months ago (2016-06-14 21:30:56 UTC) #4

bokan

The CQ bit was checked by bokan@chromium.org to run a CQ dry run

4 years, 6 months ago (2016-06-15 22:51:32 UTC) #5

commit-bot: I haz the power

Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2069713002/40001

4 years, 6 months ago (2016-06-15 22:52:03 UTC) #6

bokan

The CQ bit was checked by bokan@chromium.org to run a CQ dry run

4 years, 6 months ago (2016-06-15 23:48:10 UTC) #7

commit-bot: I haz the power

Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2069713002/60001

4 years, 6 months ago (2016-06-15 23:48:52 UTC) #8

bokan

The CQ bit was checked by bokan@chromium.org to run a CQ dry run

4 years, 6 months ago (2016-06-16 01:27:55 UTC) #9

commit-bot: I haz the power

Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2069713002/80001

4 years, 6 months ago (2016-06-16 01:28:28 UTC) #10

commit-bot: I haz the power

The CQ bit was unchecked by commit-bot@chromium.org

4 years, 6 months ago (2016-06-16 02:37:24 UTC) #11

commit-bot: I haz the power

Dry run: Try jobs failed on following builders: mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_rel/builds/128120)

4 years, 6 months ago (2016-06-16 02:37:25 UTC) #12

bokan

The CQ bit was checked by bokan@chromium.org to run a CQ dry run

4 years, 6 months ago (2016-06-16 08:29:26 UTC) #13

commit-bot: I haz the power

Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2069713002/100001

4 years, 6 months ago (2016-06-16 08:29:37 UTC) #14

commit-bot: I haz the power

The CQ bit was unchecked by commit-bot@chromium.org

4 years, 6 months ago (2016-06-16 10:33:59 UTC) #15

commit-bot: I haz the power

Dry run: This issue passed the CQ dry run.

4 years, 6 months ago (2016-06-16 10:34:00 UTC) #16

bokan

Description was changed from ========== <WIP> Gesture scrolls are now on scroll customization path BUG= ...

4 years, 6 months ago (2016-06-16 13:59:23 UTC) #17

bokan

bokan@chromium.org changed reviewers: + tdresser@chromium.org

4 years, 6 months ago (2016-06-16 13:59:23 UTC) #18

bokan

The CQ bit was checked by bokan@chromium.org to run a CQ dry run

4 years, 6 months ago (2016-06-16 13:59:34 UTC) #19

commit-bot: I haz the power

Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2069713002/120001

4 years, 6 months ago (2016-06-16 13:59:47 UTC) #20

commit-bot: I haz the power

The CQ bit was unchecked by commit-bot@chromium.org

4 years, 6 months ago (2016-06-16 15:24:57 UTC) #22

commit-bot: I haz the power

Dry run: This issue passed the CQ dry run.

4 years, 6 months ago (2016-06-16 15:24:59 UTC) #23

tdresser

Is https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/input/ScrollManager.cpp?rcl=0&l=362 still accurate, or will we perform scroll customization for wheel now? https://codereview.chromium.org/2069713002/diff/120001/third_party/WebKit/Source/core/dom/Document.h File ...

4 years, 6 months ago (2016-06-23 14:34:29 UTC) #24

bokan

On 2016/06/23 14:34:29, tdresser wrote: > Is > https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/input/ScrollManager.cpp?rcl=0&l=362 > still accurate, or will we ...

4 years, 6 months ago (2016-06-23 16:11:25 UTC) #25

bokan

https://codereview.chromium.org/2069713002/diff/120001/third_party/WebKit/Source/core/dom/Document.h File third_party/WebKit/Source/core/dom/Document.h (right): https://codereview.chromium.org/2069713002/diff/120001/third_party/WebKit/Source/core/dom/Document.h#newcode1086 third_party/WebKit/Source/core/dom/Document.h:1086: Element* effectiveRootScroller() const; On 2016/06/23 14:34:29, tdresser wrote: > ...

4 years, 6 months ago (2016-06-23 16:12:30 UTC) #26

tdresser

Hmmm, it's a bit of a pain as this is a refactor, but could you ...

4 years, 6 months ago (2016-06-23 16:16:51 UTC) #27

tdresser

On 2016/06/23 20:34:40, tdresser wrote: > LGTM module comments. s/module/modulo

4 years, 6 months ago (2016-06-23 20:34:53 UTC) #29

bokan

The patchset sent to the CQ was uploaded after l-g-t-m from tdresser@chromium.org Link to the ...

4 years, 6 months ago (2016-06-24 19:16:08 UTC) #31

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2069713002/180001

4 years, 6 months ago (2016-06-24 19:16:59 UTC) #32

commit-bot: I haz the power

The CQ bit was unchecked by commit-bot@chromium.org

4 years, 6 months ago (2016-06-24 20:43:45 UTC) #33

commit-bot: I haz the power

Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/245138)

4 years, 6 months ago (2016-06-24 20:43:47 UTC) #34

bokan

The patchset sent to the CQ was uploaded after l-g-t-m from tdresser@chromium.org Link to the ...

4 years, 6 months ago (2016-06-24 21:22:14 UTC) #36

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2069713002/200001

4 years, 6 months ago (2016-06-24 21:22:41 UTC) #37

commit-bot: I haz the power

Description was changed from ========== Make all gesture scrolls use customization path internally This patch ...

4 years, 6 months ago (2016-06-24 22:45:27 UTC) #38

Message was sent while issue was closed.

Description was changed from

==========
Make all gesture scrolls use customization path internally

This patch removes the physicalScroll code path in ScrollManager.
This means that all gesture scrolls are now taking the ScrollCustomization
path through scrolling; building a scroll chain, calling distribute and
apply scroll.

Some notable changes here:

iframes now also scroll like the main frame, using a ViewportScrollCallback
but without affecting top controls or overscroll.

The ScrollChain calculated in ScrollCustomization used to end on the
scrollingElement. It now terminates at the RootScroller. This is so that
1) the RootScroller API works as expected when the page sets a root
scroller and 2) if the scrollingElement is <body>, we still want to chain
the scroll up to the documentElement (assuming it's the root scroller)
since that'll actually scroll the frame and top controls.

Clear m_deltaConsumedForScrollSequence on GestureScrollBegin. Otherwise,
this doesn't get cleared during a fling gesture so a new scroll during
the fling will get dropped in the ScrollCustomization path.

BUG=620721
==========

to

==========
Make all gesture scrolls use customization path internally

This patch removes the physicalScroll code path in ScrollManager.
This means that all gesture scrolls are now taking the ScrollCustomization
path through scrolling; building a scroll chain, calling distribute and
apply scroll.

Some notable changes here:

iframes now also scroll like the main frame, using a ViewportScrollCallback
but without affecting top controls or overscroll.

The ScrollChain calculated in ScrollCustomization used to end on the
scrollingElement. It now terminates at the RootScroller. This is so that
1) the RootScroller API works as expected when the page sets a root
scroller and 2) if the scrollingElement is <body>, we still want to chain
the scroll up to the documentElement (assuming it's the root scroller)
since that'll actually scroll the frame and top controls.

Clear m_deltaConsumedForScrollSequence on GestureScrollBegin. Otherwise,
this doesn't get cleared during a fling gesture so a new scroll during
the fling will get dropped in the ScrollCustomization path.

BUG=620721
==========

commit-bot: I haz the power

Description was changed from ========== Make all gesture scrolls use customization path internally This patch ...

4 years, 6 months ago (2016-06-24 22:47:08 UTC) #40

Message was sent while issue was closed.

Description was changed from

==========
Make all gesture scrolls use customization path internally

This patch removes the physicalScroll code path in ScrollManager.
This means that all gesture scrolls are now taking the ScrollCustomization
path through scrolling; building a scroll chain, calling distribute and
apply scroll.

Some notable changes here:

iframes now also scroll like the main frame, using a ViewportScrollCallback
but without affecting top controls or overscroll.

The ScrollChain calculated in ScrollCustomization used to end on the
scrollingElement. It now terminates at the RootScroller. This is so that
1) the RootScroller API works as expected when the page sets a root
scroller and 2) if the scrollingElement is <body>, we still want to chain
the scroll up to the documentElement (assuming it's the root scroller)
since that'll actually scroll the frame and top controls.

Clear m_deltaConsumedForScrollSequence on GestureScrollBegin. Otherwise,
this doesn't get cleared during a fling gesture so a new scroll during
the fling will get dropped in the ScrollCustomization path.

BUG=620721
==========

to

==========
Make all gesture scrolls use customization path internally

This patch removes the physicalScroll code path in ScrollManager.
This means that all gesture scrolls are now taking the ScrollCustomization
path through scrolling; building a scroll chain, calling distribute and
apply scroll.

Some notable changes here:

iframes now also scroll like the main frame, using a ViewportScrollCallback
but without affecting top controls or overscroll.

The ScrollChain calculated in ScrollCustomization used to end on the
scrollingElement. It now terminates at the RootScroller. This is so that
1) the RootScroller API works as expected when the page sets a root
scroller and 2) if the scrollingElement is <body>, we still want to chain
the scroll up to the documentElement (assuming it's the root scroller)
since that'll actually scroll the frame and top controls.

Clear m_deltaConsumedForScrollSequence on GestureScrollBegin. Otherwise,
this doesn't get cleared during a fling gesture so a new scroll during
the fling will get dropped in the ScrollCustomization path.

BUG=620721

Committed: https://crrev.com/c81f2158da2b43ae5a8b0c5d0e0fcf3b5d2c8b98
Cr-Commit-Position: refs/heads/master@{#401997}
==========

commit-bot: I haz the power

4 years, 6 months ago (2016-06-24 22:47:10 UTC) #41

Message was sent while issue was closed.

Patchset 11 (id:??) landed as
https://crrev.com/c81f2158da2b43ae5a8b0c5d0e0fcf3b5d2c8b98
Cr-Commit-Position: refs/heads/master@{#401997}

Issue 2069713002: Make all gesture scrolls use customization path internally (Closed)

Description

Patch Set 1 #

Patch Set 2 : Gesture scrolls are now on scroll customization path #

Patch Set 3 : Gesture scrolls are now on scroll customization path #

Patch Set 4 : Gesture scrolls are now on scroll customization path #

Patch Set 5 : Gesture scrolls are now on scroll customization path #

Patch Set 6 : Gesture scrolls are now on scroll customization path #

Patch Set 7 : Gesture scrolls are now on scroll customization path #

Patch Set 8 : Rebase #

Patch Set 9 : Tim's review #

Patch Set 10 : Disabled customization for wheel scrolls #

Patch Set 11 : Rebase + Fix test #

Messages