Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2069663002: Some scoped_ptr -> std::unique_ptr conversion, especially under //mojo. (Closed)

Created:
4 years, 6 months ago by viettrungluu
Modified:
4 years, 6 months ago
Reviewers:
azani
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Some scoped_ptr -> std::unique_ptr conversion, especially under //mojo. R=azani@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/c90b1c7c97ac9665430d6a7b29819a2ec48e1f0e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -52 lines) Patch
M examples/forwarding_content_handler/forwarding_content_handler.cc View 2 chunks +1 line, -2 lines 0 comments Download
M examples/recursive_content_handler/recursive_content_handler.cc View 2 chunks +1 line, -2 lines 0 comments Download
M mojo/android/system/core_impl.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M mojo/application/content_handler_factory.h View 3 chunks +7 lines, -5 lines 0 comments Download
M mojo/converters/native_viewport/surface_configuration_type_converters.h View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/converters/ozone_drm_gpu/ozone_drm_gpu_type_converters.h View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/dart/embedder/builtin_natives.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M mojo/data_pipe_utils/data_pipe_file_utils.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M mojo/gles2/command_buffer_client_impl.h View 2 chunks +3 lines, -3 lines 0 comments Download
M mojo/gles2/command_buffer_client_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/gles2/control_thunks_impl.cc View 2 chunks +3 lines, -1 line 0 comments Download
M mojo/gles2/gles2_context.h View 2 chunks +5 lines, -4 lines 0 comments Download
M mojo/message_pump/handle_watcher.h View 2 chunks +4 lines, -3 lines 0 comments Download
M mojo/message_pump/handle_watcher_unittest.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M mojo/message_pump/message_pump_mojo.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M mojo/message_pump/message_pump_mojo_unittest.cc View 1 chunk +1 line, -5 lines 0 comments Download
M mojo/nacl/nonsfi/file_util.cc View 4 chunks +9 lines, -3 lines 0 comments Download
M mojo/nacl/nonsfi/irt_pnacl_translator_compile.cc View 3 chunks +5 lines, -2 lines 0 comments Download
M services/dart/content_handler_app.h View 1 chunk +1 line, -1 line 0 comments Download
M services/dart/content_handler_app.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M services/js/content_handler_main.cc View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
viettrungluu
4 years, 6 months ago (2016-06-14 17:27:10 UTC) #1
azani
lgtm
4 years, 6 months ago (2016-06-14 17:44:52 UTC) #2
viettrungluu
4 years, 6 months ago (2016-06-14 17:51:48 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
c90b1c7c97ac9665430d6a7b29819a2ec48e1f0e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698