Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Unified Diff: tool/input_sdk/private/ddc_runtime/types.dart

Issue 2069653003: Fix function subtyping crash (Closed) Base URL: git@github.com:dart-lang/dev_compiler.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/codegen/language/function_subtype_regression_ddc_588_test.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tool/input_sdk/private/ddc_runtime/types.dart
diff --git a/tool/input_sdk/private/ddc_runtime/types.dart b/tool/input_sdk/private/ddc_runtime/types.dart
index e4ad0353d542a21eb67cac099129bff82a8bde5f..3ed88b844560dfadb29f8175ab80618762d39c1a 100644
--- a/tool/input_sdk/private/ddc_runtime/types.dart
+++ b/tool/input_sdk/private/ddc_runtime/types.dart
@@ -496,6 +496,10 @@ isFunctionSubtype(ft1, ft2, covariant) => JS('', '''(() => {
return true;
}
+ if ($ft1 === $Function) {
+ return false;
+ }
+
let ret1 = $ft1.returnType;
let ret2 = $ft2.returnType;
« no previous file with comments | « test/codegen/language/function_subtype_regression_ddc_588_test.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698