Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 2069593002: Suppress libpng clang warning on GYP (Closed)

Created:
4 years, 6 months ago by msarett
Modified:
4 years, 6 months ago
Reviewers:
Nico
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Suppress libpng clang warning on GYP The BUILD.gn already has this flag. BUG=599917 NOTRY=true Committed: https://crrev.com/66b307a3e6a01abc681849e161cd39299ddf3791 Cr-Commit-Position: refs/heads/master@{#399744}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M third_party/libpng/libpng.gyp View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
msarett
4 years, 6 months ago (2016-06-14 14:00:16 UTC) #2
Nico
lgtm, thanks!
4 years, 6 months ago (2016-06-14 14:01:12 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2069593002/1
4 years, 6 months ago (2016-06-14 14:06:48 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2069593002/1
4 years, 6 months ago (2016-06-14 17:49:56 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-14 17:55:36 UTC) #12
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-14 17:55:42 UTC) #13
commit-bot: I haz the power
4 years, 6 months ago (2016-06-14 17:57:45 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/66b307a3e6a01abc681849e161cd39299ddf3791
Cr-Commit-Position: refs/heads/master@{#399744}

Powered by Google App Engine
This is Rietveld 408576698