Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 2069573002: Revert of Remove ineffective PendingScript prefinalizer (2nd attempt.) (Closed)

Created:
4 years, 6 months ago by sof
Modified:
4 years, 6 months ago
Reviewers:
haraken
CC:
chromium-reviews, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Remove ineffective PendingScript prefinalizer (2nd attempt.) (patchset #1 id:1 of https://codereview.chromium.org/2060853002/ ) Reason for revert: Canary crashes reported, https://bugs.chromium.org/p/chromium/issues/detail?id=615977#c12 Original issue's description: > Remove ineffective PendingScript prefinalizer (2nd attempt.) > > With the missing case from r397106 aboard, retire the prefinalizer > for PendingScript. Script loader and runner objects are expected > to explicitly dispose of these upon success or failure. > > R= > BUG= > > Committed: https://crrev.com/fbf7f01ae80f666a5b37acf0ef38fd174443787f > Cr-Commit-Position: refs/heads/master@{#399504} TBR=haraken@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/cb0b8cd6962b00abf23a9779d13eee15af316693 Cr-Commit-Position: refs/heads/master@{#399691}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M third_party/WebKit/Source/core/dom/PendingScript.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/PendingScript.cpp View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
sof
Created Revert of Remove ineffective PendingScript prefinalizer (2nd attempt.)
4 years, 6 months ago (2016-06-14 13:21:23 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2069573002/1
4 years, 6 months ago (2016-06-14 13:21:40 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-14 13:22:18 UTC) #5
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-14 13:22:19 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/cb0b8cd6962b00abf23a9779d13eee15af316693 Cr-Commit-Position: refs/heads/master@{#399691}
4 years, 6 months ago (2016-06-14 13:23:31 UTC) #8
haraken
4 years, 6 months ago (2016-06-14 15:09:07 UTC) #9
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698