Add base::Feature to protect password viewing on Android

Add base::Feature to protect password viewing on Android

This CL adds a base::Feature "view-passwords" to guard the ability to view and copy passwords in Chrome on Android settings.

Note: There is no associated about::flags entry because it is crucial that the feature not be enabled by non-developers before it is complete.

BUG=619868
Committed: https://crrev.com/4630cceb0e4cd565ff9b5b95d841587fda1814f5
Cr-Commit-Position: refs/heads/master@{#399679}

[dozsa, 2016-06-14 09:26:13]

dozsa@google.com changed reviewers:
+ vabr@chromium.org

[dozsa, 2016-06-14 09:27:07]

Hi Vaclav,

Could you please review this change?

Thank you!
Paula

[dozsa, 2016-06-14 09:27:39]

Description was changed from

==========
Add feature to protet password viewing and copying in the Settings->Save
Paswords tab for Android.
==========

to

==========
Add feature to protect password viewing and copying in the Settings->Save
Paswords tab for Android.
==========

[vabr (Chromium), 2016-06-14 09:43:53]

Hi Paula,

Thanks, this LGTM with one comment in the code, and the following comments for
the CL description:
 * Please make the title shorter; ideally under 80 characters to show up nicely
in git log.
 * Please mention the associated BUG number.
 * Please use base::Feature instead of just "feature" to avoid confusion whether
this CL adds the whole feature or just the flag.
 * Please mention that we are on purpose not including this in the about:flags.
(I forgot to mention this, but you did the right thing anyway. :))

To satisfy that, I suggest changing the Cl description to:

----------------------------------------------------
Add a base::Feature for password viewing on Android

This CL adds a base::Feature "view-passwords" to guard the ability
to view and copy passwords in the Chrome on Android settings.

There is on purpose no associated about:flags entry, because it
is crucial that the feature cannot be turned on by non-developers
before it is ready.

BUG=619868
----------------------------------------------------

https://codereview.chromium.org/2069553002/diff/1/components/password_manager...
File components/password_manager/core/common/password_manager_features.cc
(right):

https://codereview.chromium.org/2069553002/diff/1/components/password_manager...
components/password_manager/core/common/password_manager_features.cc:52: //
Control whether users can view and copy passwords.
nit: Please also state that this is only used for Android at the moment, and
that desktop Chrome always allows users to view passwords.

[dozsa, 2016-06-14 09:52:14]

Description was changed from

==========
Add feature to protect password viewing and copying in the Settings->Save
Paswords tab for Android.
==========

to

==========
This CL adds a base::Feature "view-passwords" to guard the ability to view and
copy passwords in Chrome on Android settings.

Note: There is no associated about::flags entry because it is crucial that the
feature not be enabled by non-developers before it is complete.

BUG=619868
==========

[dozsa, 2016-06-14 09:55:35]

https://codereview.chromium.org/2069553002/diff/1/components/password_manager...
File components/password_manager/core/common/password_manager_features.cc
(right):

https://codereview.chromium.org/2069553002/diff/1/components/password_manager...
components/password_manager/core/common/password_manager_features.cc:52: //
Control whether users can view and copy passwords.
On 2016/06/14 09:43:53, vabr (Chromium) wrote:
> nit: Please also state that this is only used for Android at the moment, and
> that desktop Chrome always allows users to view passwords.

Done.

[vabr (Chromium), 2016-06-14 09:58:44]

Description was changed from

==========
This CL adds a base::Feature "view-passwords" to guard the ability to view and
copy passwords in Chrome on Android settings.

Note: There is no associated about::flags entry because it is crucial that the
feature not be enabled by non-developers before it is complete.

BUG=619868
==========

to

==========
Add base::Feature to protect password viewing on Android

This CL adds a base::Feature "view-passwords" to guard the ability to view and
copy passwords in Chrome on Android settings.

Note: There is no associated about::flags entry because it is crucial that the
feature not be enabled by non-developers before it is complete.

BUG=619868
==========

[vabr (Chromium), 2016-06-14 09:59:40]

LGTM, thanks!

Vaclav

P.S. I just copied the title to the CL description again. It is a duplicity, but
the git commit message is generated from the description only, that's why it has
the title repeated.

[dozsa, 2016-06-14 10:00:52]

The CQ bit was checked by dozsa@google.com

[commit-bot: I haz the power, 2016-06-14 10:01:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2069553002/20001

[commit-bot: I haz the power, 2016-06-14 10:39:26]

Description was changed from

==========
Add base::Feature to protect password viewing on Android

This CL adds a base::Feature "view-passwords" to guard the ability to view and
copy passwords in Chrome on Android settings.

Note: There is no associated about::flags entry because it is crucial that the
feature not be enabled by non-developers before it is complete.

BUG=619868
==========

to

==========
Add base::Feature to protect password viewing on Android

This CL adds a base::Feature "view-passwords" to guard the ability to view and
copy passwords in Chrome on Android settings.

Note: There is no associated about::flags entry because it is crucial that the
feature not be enabled by non-developers before it is complete.

BUG=619868
==========

[commit-bot: I haz the power, 2016-06-14 10:39:27]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-06-14 10:41:10]

Description was changed from

==========
Add base::Feature to protect password viewing on Android

This CL adds a base::Feature "view-passwords" to guard the ability to view and
copy passwords in Chrome on Android settings.

Note: There is no associated about::flags entry because it is crucial that the
feature not be enabled by non-developers before it is complete.

BUG=619868
==========

to

==========
Add base::Feature to protect password viewing on Android

This CL adds a base::Feature "view-passwords" to guard the ability to view and
copy passwords in Chrome on Android settings.

Note: There is no associated about::flags entry because it is crucial that the
feature not be enabled by non-developers before it is complete.

BUG=619868

Committed: https://crrev.com/4630cceb0e4cd565ff9b5b95d841587fda1814f5
Cr-Commit-Position: refs/heads/master@{#399679}
==========

[commit-bot: I haz the power, 2016-06-14 10:41:11]

Patchset 2 (id:??) landed as
https://crrev.com/4630cceb0e4cd565ff9b5b95d841587fda1814f5
Cr-Commit-Position: refs/heads/master@{#399679}