Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 2069543007: [d8] Make exception reporting more resilient. (Closed)

Created:
4 years, 6 months ago by Michael Starzinger
Modified:
4 years, 6 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[d8] Make exception reporting more resilient. This makes sure exception reporting done by the debug shell behaves gracefully even near the stack limit. When line number determination fails we just fallback to not printing source information. R=yangguo@chromium.org TEST=mjsunit/regress/regress-crbug-620253 BUG=chromium:620253 Committed: https://crrev.com/e55384b28e2354b384dbbe3821af10065566231a Cr-Commit-Position: refs/heads/master@{#37031}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -19 lines) Patch
M src/d8.cc View 1 chunk +20 lines, -17 lines 0 comments Download
A + test/mjsunit/regress/regress-crbug-620253.js View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Michael Starzinger
4 years, 6 months ago (2016-06-16 09:45:50 UTC) #1
Yang
On 2016/06/16 09:45:50, Michael Starzinger wrote: lgtm
4 years, 6 months ago (2016-06-16 09:49:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2069543007/1
4 years, 6 months ago (2016-06-16 09:51:04 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-16 10:12:14 UTC) #5
commit-bot: I haz the power
4 years, 6 months ago (2016-06-16 10:14:17 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e55384b28e2354b384dbbe3821af10065566231a
Cr-Commit-Position: refs/heads/master@{#37031}

Powered by Google App Engine
This is Rietveld 408576698