Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(363)

Issue 2069543006: [Mac/GN] Make //components/crash/core/common a static_library. (Closed)

Created:
4 years, 6 months ago by Robert Sesek
Modified:
4 years, 6 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Mac/GN] Make //components/crash/core/common a static_library. On Mac, if it is a source_set, error messages like this will be printed, since the .o file ends up in multiple targets: objc[56710]: Class CrZombie is implemented in both /Volumes/Build/src/out/shared/./libsessions.dylib and /Volumes/Build/src/out/shared/libchrome_dll.dylib. One of the two will be used. Which one is undefined. BUG=611894 R=mark@chromium.org Committed: https://crrev.com/73d41be15a231987117bd4e932219de569f37a9c Cr-Commit-Position: refs/heads/master@{#399922}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M components/crash/core/common/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Robert Sesek
4 years, 6 months ago (2016-06-15 15:41:40 UTC) #1
Mark Mentovai
LGTM Yeah…
4 years, 6 months ago (2016-06-15 15:43:34 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2069543006/1
4 years, 6 months ago (2016-06-15 15:44:22 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-15 16:34:11 UTC) #5
commit-bot: I haz the power
4 years, 6 months ago (2016-06-15 16:36:39 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/73d41be15a231987117bd4e932219de569f37a9c
Cr-Commit-Position: refs/heads/master@{#399922}

Powered by Google App Engine
This is Rietveld 408576698