Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7758)

Unified Diff: chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js

Issue 2069543004: Adjust output rules related menus (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/chromeos/chromevox/cvox2/background/desktop_automation_handler.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js
diff --git a/chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js b/chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js
index c556d59aed984ef9eb3677a760d940927a28bbf3..91914da7163c82813dce25d489aaa8f913d3f6ae 100644
--- a/chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js
+++ b/chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js
@@ -230,8 +230,7 @@ Output.ROLE_INFO_ = {
msgId: 'role_menubar',
},
menuItem: {
- msgId: 'role_menuitem',
- earconId: 'BUTTON'
dmazzoni 2016/06/14 21:46:32 Did you mean to get rid of the earcon for menuItem
David Tseng 2016/06/15 22:59:20 I did; not sure how you feel about it, but output
+ msgId: 'role_menuitem'
},
menuItemCheckBox: {
msgId: 'role_menuitemcheckbox',
@@ -471,6 +470,10 @@ Output.RULES = {
'@describe_index($indexInParent, $parentChildCount) ' +
'$description'
},
+ menuItemCheckBox: {
+ speak: '$if($checked, $earcon(CHECK_ON), $earcon(CHECK_OFF)) ' +
+ '$name $role $checked $description'
+ },
menuListOption: {
speak: '$name @role_menuitem ' +
'@describe_index($indexInParent, $parentChildCount) $description'
« no previous file with comments | « chrome/browser/resources/chromeos/chromevox/cvox2/background/desktop_automation_handler.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698