infra/bots/assets/scripts/upload.py - Issue 2069543002: Add asset management scripts

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: infra/bots/assets/scripts/upload.py

Issue 2069543002: Add asset management scripts (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Add FYI prints for asset creation Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 #!/usr/bin/env python

	2 #

	3 # Copyright 2016 Google Inc.

	4 #

	5 # Use of this source code is governed by a BSD-style license that can be

	6 # found in the LICENSE file.

	7

	8

	9 """Upload a new version of the asset."""

	10

	11

	12 import os

	13 import sys

	14

	15 FILE_DIR = os.path.dirname(os.path.abspath(__file__))

	16 INFRA_BOTS_DIR = os.path.realpath(os.path.join(FILE_DIR, os.pardir, os.pardir))

	17

	18 sys.path.insert(0, INFRA_BOTS_DIR)
	rmistry 2016/06/15 13:47:18 The top 4 lines are in 3 scripts. Might be able to The top 4 lines are in 3 scripts. Might be able to extract into a util and add a add_infra_to_path() function. I remember seeing that pattern in telemetry somewhere but now I cannot find it to show you an example :/ borenet 2016/06/15 14:31:27 Extracted into common.py, no function needed. It Show quoted text On 2016/06/15 13:47:18, rmistry wrote: > The top 4 lines are in 3 scripts. Might be able to extract into a util and add a > add_infra_to_path() function. I remember seeing that pattern in telemetry > somewhere but now I cannot find it to show you an example :/ Extracted into common.py, no function needed. It made these scripts a lot smaller :)
	19 from assets import assets

	20

	21 ASSET_NAME = os.path.basename(FILE_DIR)

	22

	23

	24 if __name__ == '__main__':

	25 assets.main(['upload', ASSET_NAME] + sys.argv[1:])

OLD	NEW