infra/bots/assets/scripts/download.py - Issue 2069543002: Add asset management scripts

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: infra/bots/assets/scripts/download.py

Issue 2069543002: Add asset management scripts (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Add FYI prints for asset creation Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« infra/bots/assets/scripts/create_and_upload.py ('K') | « infra/bots/assets/scripts/create_and_upload.py ('k') | infra/bots/assets/scripts/upload.py » ('j') | infra/bots/assets/scripts/upload.py » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 #!/usr/bin/env python

	2 #

	3 # Copyright 2016 Google Inc.

	4 #

	5 # Use of this source code is governed by a BSD-style license that can be

	6 # found in the LICENSE file.

	7

	8

	9 """Download the current version of the asset."""

	10

	11

	12 import os

	13 import sys

	14

	15 FILE_DIR = os.path.dirname(os.path.abspath(__file__))

	16 INFRA_BOTS_DIR = os.path.realpath(os.path.join(FILE_DIR, os.pardir, os.pardir))

	17

	18 sys.path.insert(0, INFRA_BOTS_DIR)

	19 from assets import assets

	20

	21 ASSET_NAME = os.path.basename(FILE_DIR)

	22

	23

	24 if __name__ == '__main__':

	25 assets.main(['download', ASSET_NAME] + sys.argv[1:])
	rmistry 2016/06/15 13:47:18 sys.exit(...) here and in all scripts with "if __n sys.exit(...) here and in all scripts with "if __name__ == '__main__'" MA always asks for this and I tend to agree. borenet 2016/06/15 14:31:27 I'm not sure what you mean. We'll exit with code Show quoted text On 2016/06/15 13:47:18, rmistry wrote: > sys.exit(...) here and in all scripts with "if __name__ == '__main__'" > MA always asks for this and I tend to agree. I'm not sure what you mean. We'll exit with code zero if there's no exception, and since we don't trap exceptions, those will cause us to exit with non-zero code. rmistry 2016/06/15 14:49:40 Right, the advantage of using sys.exit is when the Show quoted text On 2016/06/15 14:31:27, borenet wrote: > On 2016/06/15 13:47:18, rmistry wrote: > > sys.exit(...) here and in all scripts with "if __name__ == '__main__'" > > MA always asks for this and I tend to agree. > > I'm not sure what you mean. We'll exit with code zero if there's no exception, > and since we don't trap exceptions, those will cause us to exit with non-zero > code. Right, the advantage of using sys.exit is when the function you call returns specific ret codes. You do not need it here because you control everything you call. I like using it in general because it handles ret codes in addition to Exceptions incase anything changes in the future. What you have right now is fine.
OLD	NEW